Additional Meta Events that Contain Text #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommended Practice 19 (RP-019) adds two Meta Events to the MIDI Standard:
Program Name 0xFF08, len, text
Device Name 0xFF09, len, text
See: MIDI Association: SMF Device Name and Program Name Meta Events
These Meta Events were accepted by the MIDI Manufacturers Association (MMA) on 10 April 1998 and by the Association of Musical Electronics Industry (AMEI) on 7 May 1999 and have thus become part of the Standard MIDI File specification.
I deal with MIDI files that contain these Meta Events. I would like cxxmidi to handle these events more seamlessly.
This Pull Request adds these two Meta Events to the MetaType enum in the Message class.
In addition, this PR updates the Message::ContainsText() method to include these and all other Meta Events that include text, such as Message::MetaType::kMarker and Message::MetaType::kCuePoint.