Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gsn support #79

Draft
wants to merge 3 commits into
base: development
Choose a base branch
from
Draft

Gsn support #79

wants to merge 3 commits into from

Conversation

drortirosh
Copy link

add GSN support for contract-proxy-kit

based on tpi code.
passes (most) of the tests for web3.

note that most adaptations is for the tests, and not for the proxy kit itself
(e.g. the test assume it can use the "proxyOwner' for tokens - but with GSN, the proxy owner is "gasless" and can't approve. so for testing purposes we need a non-GSN "tokenOwner" to generate and approve those tokens - the Safe itself (even through GSN) can handle those tokens perfectly well...

yarn "gsn-ganache" to start ganache with local gsn.
added "forwarder" as param to CPKFactory.
use "usingGSN" flag to enable/disable test with GSN
also mark tests to skip in GSN (e.g. checking for gas)
"with fresh account" fail no fixure problem
@germartinez germartinez changed the base branch from master to development July 15, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant