Update types to remove ResumableFile.progress argument, add ResumableChunk progress type #521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might be misinterpreting the source code, but I think the ResumableFile.progress function doesn't seem to take any arguments, where the ResumableChunk.progress does take an optional argument.
I was initially going to just make the ResumableFile.progress argument optional, and while that will fix the issue I'm running in to, I found what I thought was a larger issue, thus my type changes.
In
ResumableFile
:And in
ResumableChunk
: