Merge pull request #2036 from 18F/mb-voice-otp

Rescue errors parsing voice OTP encrypted code
18F · Mar 5, 2018 · e2d1361 · e2d1361
2 parents 2b59beb + 01c50e6
commit e2d1361
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/app/controllers/voice/otp_controller.rb b/app/controllers/voice/otp_controller.rb
@@ -24,6 +24,8 @@ def code
       return if encrypted_code.blank?
 
       cipher.decrypt(encrypted_code)
+    rescue StandardError
+      nil
     end
 
     def message

diff --git a/spec/controllers/voice/otp_controller_spec.rb b/spec/controllers/voice/otp_controller_spec.rb
@@ -22,6 +22,17 @@
       end
     end
 
+    context 'with an invalid encrypted_code in the URL' do
+      let(:encrypted_code) { '%25' }
+
+      it 'renders a blank 400' do
+        action
+
+        expect(response).to be_bad_request
+        expect(response.body).to be_empty
+      end
+    end
+
     context 'with an encrypted_code in the URL' do
       render_views