feat: split v2.1 #55
Merged
feat: split v2.1 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we aren't redeploying |
wminshew
reviewed
Dec 18, 2024
| return split; | ||
| } | ||
|
|
||
| split = Clone.cloneDeterministic({ _implementation: SPLIT_WALLET_IMPLEMENTATION, _salt: salt }); |
There was a problem hiding this comment.
hm is it more performant to make the clone in a try/catch and then do the predict / code length check in the catch? makes the happy-case better (which should be ~100% of usage?)
don't feel strongly about it.. not sure how much we're actually shaving off
There was a problem hiding this comment.
realized while implementing that try catch is only allowed for external function calls so this won't be possible without creating a wrapper create function, going to keep this as is for now
|
as discussed on discord,
if you can keep pushing the ball forward w/o deploying, great. if not, just deploy and i'll review in the AM |
|
ah right bummer
…---
splits <https://splits.org/> | @wminshew <https://twitter.com/wminshew> |
willminshew.com <http://www.willminshew.com>
On Wed, Dec 18, 2024 at 04:38 Rooh Afza ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In packages/splits-v2/src/splitters/SplitFactoryV2.sol
<#55 (comment)>
:
> });
+ if (split.code.length > 0) {
+ return split;
+ }
+
+ split = Clone.cloneDeterministic({ _implementation: SPLIT_WALLET_IMPLEMENTATION, _salt: salt });
realized while implementing that try catch is only allowed for external
function calls so this won't be possible without creating a wrapper create
function, going to keep this as is for now
—
Reply to this email directly, view it on GitHub
<#55 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACLDV7S4SBXZ6VIEYKGBEXT2GFUGHAVCNFSM6AAAAABTXVEOUCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMJRG4YTIMZRGY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.