Feat: Multichain payment #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinsaporiti
previously requested changes
Nov 15, 2024
|
@martinsaporiti There are 2 concepts by now. Payments and PaymentOptions. Payments will be linked to PaymentOptions. I was in doubt of splitting it into 2 services: Payments and PaymentOptions , or to use just one. What do you think? Should we divide it into 2 services? |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 14295020 | Triggered | Generic High Entropy Secret | daaeebc | internal/kms/aws_secret_storage_provider_test.go | View secret |
| 8664826 | Triggered | Generic Password | e8d8158 | k8s/testing/values.yaml | View secret |
| 14295020 | Triggered | Generic High Entropy Secret | a823a07 | internal/kms/aws_secret_storage_provider_test.go | View secret |
| 14295020 | Triggered | Generic High Entropy Secret | a823a07 | internal/kms/aws_secret_storage_provider_test.go | View secret |
| 14295020 | Triggered | Generic High Entropy Secret | a823a07 | internal/kms/aws_secret_storage_provider_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
feat: Remove unneded level paymentOption.config.config
…multichain-payment
feat: Pass schema id in Create PaymentRequest message endpoint. feat: Change response in Create PaymentRequest message endpoint.
…yment # Conflicts: # api/api.yaml # cmd/platform/main.go # internal/api/api.gen.go # internal/api/main_test.go # internal/api/server.go
demonsh
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.