-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hiding sourcemaps causes Cordova HCP to fail #23
Comments
Maybe I'm being overzealous and I only need to remove the |
Also it occurs to me that this is perhaps a "bug" in the meteor cordova plugin in that it should potentially warn instead of fail in the case that the source maps are not available... |
Thanks for reporting this, and for your solution... I discovered this myself after some banging of head against wall, and was glad to see I wasn't the only one, and even more happy to find a quick solution via updating my build script. For anyone reading this who wants to take a stab at addressing the root problem of the update failing with missing sourcemaps, the error is coming from cordova-plugin-meteor-webapp – specifically, this function. But I'm going to just stick with the workaround for now. |
Does cordova actually use the source maps? We could have Webapp serve an empty source map instead. |
I don't know if Cordova itself does. But I would certainly love it if I could get sourcemapped tracebacks in my error tracking service of choice. |
If cordova does, we can create a source map that is valid but doesn't do anything, but it will be slower.
I haven't tried it with cordova, but I thought it would work the same as with the web architectures. What have you tried and what issues exist? |
Did you yield a solution here @hexsprite we also use Cordova and Rollbar and cant get sourcemaps. ;/ |
The sourcemap is listened in the
__cordova/manifest.json
but it results in a 404 error causing the meteor cordova plugin to give up on the download.For now I'm just using the following in my build script:
I'm not sure if that means I won't get proper sourcemaps if an error occurs in the cordova version my app or not?
The text was updated successfully, but these errors were encountered: