Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example in README.md is broken #202

Open
rhvonlehe opened this issue Feb 1, 2023 · 0 comments
Open

Example in README.md is broken #202

rhvonlehe opened this issue Feb 1, 2023 · 0 comments

Comments

@rhvonlehe
Copy link

rhvonlehe commented Feb 1, 2023

There are multiple problems with the code in main page but the two biggest ones are:

  1. the subscriber does not connect to the inproc endpoint that the server binds to
  2. the subscriber connects to two different, non-localhost, non-routable IP address that are likely not going to match anyone's subnet

The unit tests provide more workable examples to follow. The code on the main page will only frustrate new users. Suggest removing the example from the README or replace it with one that works without modification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant