Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orchard 0.10.1 depends on subtle 2.6 #452

Open
str4d opened this issue Jan 2, 2025 · 0 comments
Open

orchard 0.10.1 depends on subtle 2.6 #452

str4d opened this issue Jan 2, 2025 · 0 comments

Comments

@str4d
Copy link
Contributor

str4d commented Jan 2, 2025

We currently require subtle 2.3:

subtle = { version = "2.3", default-features = false }

However in 0.10.1 we started using CtOption::into_option (in the pczt module), which was added in subtle 2.6. We should either remove our usages of it, or raise our subtle requirement to 2.6 (which would make it incompatible in the same codebase as bip0039 0.10 as that depends on password-hash 0.3 which has subtle < 2.5 for annoying old MSRV reasons).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant