From 772ecdacf681aca9c6d2137cca611410cbdcf2a3 Mon Sep 17 00:00:00 2001 From: yoheimuta Date: Thu, 26 Sep 2019 12:29:19 +0900 Subject: [PATCH 1/7] chore: Tweak a minor run script --- BufferedLogger.xcodeproj/project.pbxproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BufferedLogger.xcodeproj/project.pbxproj b/BufferedLogger.xcodeproj/project.pbxproj index 43e41cd..b56f7df 100644 --- a/BufferedLogger.xcodeproj/project.pbxproj +++ b/BufferedLogger.xcodeproj/project.pbxproj @@ -238,7 +238,7 @@ ); runOnlyForDeploymentPostprocessing = 0; shellPath = /bin/sh; - shellScript = "set -exo pipefail\n\nPODS_ROOT=./Demo/Pods\n\nif [ -z \"$CI\" ]; then\n ${PODS_ROOT}/SwiftLint/swiftlint autocorrect\n ${PODS_ROOT}/SwiftLint/swiftlint\n\n ${PODS_ROOT}/SwiftFormat/CommandLineTool/swiftformat BufferedLogger\nelse\n ${PODS_ROOT}/SwiftLint/swiftlint --strict\n ${PODS_ROOT}/SwiftFormat/CommandLineTool/swiftformat BufferedLogger --dryrun | tee /dev/stderr | grep 'swiftformat completed. 0'\nfi"; + shellScript = "set -exo pipefail\n\nPODS_ROOT=./Demo/Pods\n\nif [ -z \"$CI\" ]; then\n ${PODS_ROOT}/SwiftLint/swiftlint autocorrect\n ${PODS_ROOT}/SwiftLint/swiftlint\n\n ${PODS_ROOT}/SwiftFormat/CommandLineTool/swiftformat BufferedLogger\nelse\n ${PODS_ROOT}/SwiftLint/swiftlint --strict\n ${PODS_ROOT}/SwiftFormat/CommandLineTool/swiftformat BufferedLogger --dryrun | tee /dev/stderr | grep 'swiftformat completed. 0'\nfi\n"; }; /* End PBXShellScriptBuildPhase section */ From 3afefd154536e5e2ea92e90cd513d572db8527d5 Mon Sep 17 00:00:00 2001 From: yoheimuta Date: Thu, 26 Sep 2019 12:30:10 +0900 Subject: [PATCH 2/7] refactor: Update to Swift5 --- BufferedLogger.xcodeproj/project.pbxproj | 6 +++--- BufferedLogger/BufferedOutput.swift | 2 +- Demo/Demo.xcodeproj/project.pbxproj | 5 +++-- Demo/Demo/AppDelegate.swift | 2 +- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/BufferedLogger.xcodeproj/project.pbxproj b/BufferedLogger.xcodeproj/project.pbxproj index b56f7df..d6a3a62 100644 --- a/BufferedLogger.xcodeproj/project.pbxproj +++ b/BufferedLogger.xcodeproj/project.pbxproj @@ -182,7 +182,7 @@ TargetAttributes = { FF887062210819340008C1B1 = { CreatedOnToolsVersion = 9.2; - LastSwiftMigration = 0920; + LastSwiftMigration = 1020; ProvisioningStyle = Automatic; }; FF88706B210819350008C1B1 = { @@ -411,7 +411,7 @@ PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)"; SKIP_INSTALL = YES; SWIFT_OPTIMIZATION_LEVEL = "-Onone"; - SWIFT_VERSION = 4.0; + SWIFT_VERSION = 5.0; TARGETED_DEVICE_FAMILY = "1,2"; VALID_ARCHS = "arm64 armv7 armv7s x86_64 i386"; }; @@ -434,7 +434,7 @@ PRODUCT_BUNDLE_IDENTIFIER = com.github.yoheimuta.BufferedLogger; PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)"; SKIP_INSTALL = YES; - SWIFT_VERSION = 4.0; + SWIFT_VERSION = 5.0; TARGETED_DEVICE_FAMILY = "1,2"; VALID_ARCHS = "arm64 armv7 armv7s x86_64 i386"; }; diff --git a/BufferedLogger/BufferedOutput.swift b/BufferedLogger/BufferedOutput.swift index 81e9ac6..6c841fd 100644 --- a/BufferedLogger/BufferedOutput.swift +++ b/BufferedLogger/BufferedOutput.swift @@ -112,7 +112,7 @@ final class BufferedOutput { userInfo: nil, repeats: true) DispatchQueue.main.async { - RunLoop.main.add(timer, forMode: .commonModes) + RunLoop.main.add(timer, forMode: RunLoop.Mode.common) } self.timer = timer } diff --git a/Demo/Demo.xcodeproj/project.pbxproj b/Demo/Demo.xcodeproj/project.pbxproj index 1d051a7..98eaf5e 100644 --- a/Demo/Demo.xcodeproj/project.pbxproj +++ b/Demo/Demo.xcodeproj/project.pbxproj @@ -132,6 +132,7 @@ TargetAttributes = { FF887085210819670008C1B1 = { CreatedOnToolsVersion = 9.2; + LastSwiftMigration = 1020; ProvisioningStyle = Automatic; }; }; @@ -353,7 +354,7 @@ LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks"; PRODUCT_BUNDLE_IDENTIFIER = com.github.yoheimuta.Demo; PRODUCT_NAME = "$(TARGET_NAME)"; - SWIFT_VERSION = 4.0; + SWIFT_VERSION = 5.0; TARGETED_DEVICE_FAMILY = "1,2"; }; name = Debug; @@ -369,7 +370,7 @@ LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks"; PRODUCT_BUNDLE_IDENTIFIER = com.github.yoheimuta.Demo; PRODUCT_NAME = "$(TARGET_NAME)"; - SWIFT_VERSION = 4.0; + SWIFT_VERSION = 5.0; TARGETED_DEVICE_FAMILY = "1,2"; }; name = Release; diff --git a/Demo/Demo/AppDelegate.swift b/Demo/Demo/AppDelegate.swift index ca9ccd6..0b8ce1e 100644 --- a/Demo/Demo/AppDelegate.swift +++ b/Demo/Demo/AppDelegate.swift @@ -16,7 +16,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate { var logger: BFLogger! func application(_: UIApplication, - didFinishLaunchingWithOptions _: [UIApplicationLaunchOptionsKey: Any]?) -> Bool { + didFinishLaunchingWithOptions _: [UIApplication.LaunchOptionsKey: Any]?) -> Bool { let writer = MyWriter() let config = Config(flushEntryCount: 5, flushInterval: 10, From 3f11620a45220c7c01e297b00dad5d9e890b95f2 Mon Sep 17 00:00:00 2001 From: yoheimuta Date: Thu, 26 Sep 2019 12:33:34 +0900 Subject: [PATCH 3/7] refactor: Tweak some followed by the system recommendations --- BufferedLogger.xcodeproj/project.pbxproj | 6 +++++- .../xcschemes/BufferedLogger.xcscheme | 4 +--- BufferedLogger/Entry.swift | 4 ++-- Demo/Demo.xcodeproj/project.pbxproj | 6 +++++- .../xcshareddata/xcschemes/Demo.xcscheme | 4 +--- Demo/Pods/Pods.xcodeproj/project.pbxproj | 15 ++++++++------- 6 files changed, 22 insertions(+), 17 deletions(-) diff --git a/BufferedLogger.xcodeproj/project.pbxproj b/BufferedLogger.xcodeproj/project.pbxproj index d6a3a62..294cc1e 100644 --- a/BufferedLogger.xcodeproj/project.pbxproj +++ b/BufferedLogger.xcodeproj/project.pbxproj @@ -177,7 +177,7 @@ isa = PBXProject; attributes = { LastSwiftUpdateCheck = 0920; - LastUpgradeCheck = 0920; + LastUpgradeCheck = 1020; ORGANIZATIONNAME = "YOSHIMUTA YOHEI"; TargetAttributes = { FF887062210819340008C1B1 = { @@ -294,6 +294,7 @@ CLANG_WARN_BOOL_CONVERSION = YES; CLANG_WARN_COMMA = YES; CLANG_WARN_CONSTANT_CONVERSION = YES; + CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES; CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; CLANG_WARN_DOCUMENTATION_COMMENTS = YES; CLANG_WARN_EMPTY_BODY = YES; @@ -301,6 +302,7 @@ CLANG_WARN_INFINITE_RECURSION = YES; CLANG_WARN_INT_CONVERSION = YES; CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES; + CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES; CLANG_WARN_OBJC_LITERAL_CONVERSION = YES; CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; CLANG_WARN_RANGE_LOOP_ANALYSIS = YES; @@ -354,6 +356,7 @@ CLANG_WARN_BOOL_CONVERSION = YES; CLANG_WARN_COMMA = YES; CLANG_WARN_CONSTANT_CONVERSION = YES; + CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES; CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; CLANG_WARN_DOCUMENTATION_COMMENTS = YES; CLANG_WARN_EMPTY_BODY = YES; @@ -361,6 +364,7 @@ CLANG_WARN_INFINITE_RECURSION = YES; CLANG_WARN_INT_CONVERSION = YES; CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES; + CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES; CLANG_WARN_OBJC_LITERAL_CONVERSION = YES; CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; CLANG_WARN_RANGE_LOOP_ANALYSIS = YES; diff --git a/BufferedLogger.xcodeproj/xcshareddata/xcschemes/BufferedLogger.xcscheme b/BufferedLogger.xcodeproj/xcshareddata/xcschemes/BufferedLogger.xcscheme index bbb2aaf..b82d0ce 100644 --- a/BufferedLogger.xcodeproj/xcshareddata/xcschemes/BufferedLogger.xcscheme +++ b/BufferedLogger.xcodeproj/xcshareddata/xcschemes/BufferedLogger.xcscheme @@ -1,6 +1,6 @@ Bool { diff --git a/Demo/Demo.xcodeproj/project.pbxproj b/Demo/Demo.xcodeproj/project.pbxproj index 98eaf5e..be66192 100644 --- a/Demo/Demo.xcodeproj/project.pbxproj +++ b/Demo/Demo.xcodeproj/project.pbxproj @@ -127,7 +127,7 @@ isa = PBXProject; attributes = { LastSwiftUpdateCheck = 0920; - LastUpgradeCheck = 0920; + LastUpgradeCheck = 1020; ORGANIZATIONNAME = "YOSHIMUTA YOHEI"; TargetAttributes = { FF887085210819670008C1B1 = { @@ -250,6 +250,7 @@ CLANG_WARN_BOOL_CONVERSION = YES; CLANG_WARN_COMMA = YES; CLANG_WARN_CONSTANT_CONVERSION = YES; + CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES; CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; CLANG_WARN_DOCUMENTATION_COMMENTS = YES; CLANG_WARN_EMPTY_BODY = YES; @@ -257,6 +258,7 @@ CLANG_WARN_INFINITE_RECURSION = YES; CLANG_WARN_INT_CONVERSION = YES; CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES; + CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES; CLANG_WARN_OBJC_LITERAL_CONVERSION = YES; CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; CLANG_WARN_RANGE_LOOP_ANALYSIS = YES; @@ -307,6 +309,7 @@ CLANG_WARN_BOOL_CONVERSION = YES; CLANG_WARN_COMMA = YES; CLANG_WARN_CONSTANT_CONVERSION = YES; + CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES; CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; CLANG_WARN_DOCUMENTATION_COMMENTS = YES; CLANG_WARN_EMPTY_BODY = YES; @@ -314,6 +317,7 @@ CLANG_WARN_INFINITE_RECURSION = YES; CLANG_WARN_INT_CONVERSION = YES; CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES; + CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES; CLANG_WARN_OBJC_LITERAL_CONVERSION = YES; CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; CLANG_WARN_RANGE_LOOP_ANALYSIS = YES; diff --git a/Demo/Demo.xcodeproj/xcshareddata/xcschemes/Demo.xcscheme b/Demo/Demo.xcodeproj/xcshareddata/xcschemes/Demo.xcscheme index eee28a0..cba7c70 100644 --- a/Demo/Demo.xcodeproj/xcshareddata/xcschemes/Demo.xcscheme +++ b/Demo/Demo.xcodeproj/xcshareddata/xcschemes/Demo.xcscheme @@ -1,6 +1,6 @@ @@ -46,7 +45,6 @@ buildConfiguration = "Debug" selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB" selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB" - language = "" launchStyle = "0" useCustomWorkingDirectory = "NO" ignoresPersistentStateOnLaunch = "NO" diff --git a/Demo/Pods/Pods.xcodeproj/project.pbxproj b/Demo/Pods/Pods.xcodeproj/project.pbxproj index 179bf65..880c2e6 100644 --- a/Demo/Pods/Pods.xcodeproj/project.pbxproj +++ b/Demo/Pods/Pods.xcodeproj/project.pbxproj @@ -3,7 +3,7 @@ archiveVersion = 1; classes = { }; - objectVersion = 48; + objectVersion = 46; objects = { /* Begin PBXBuildFile section */ @@ -20,10 +20,10 @@ 282ECFCD0084F94EC1DED9401AAFE7F5 /* Info.plist */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = ""; }; 5A16F4CFC63FAC439D7A04994F579A03 /* Foundation.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Foundation.framework; path = Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.3.sdk/System/Library/Frameworks/Foundation.framework; sourceTree = DEVELOPER_DIR; }; 5EFCFC4782B9646B842EB839A267D7AA /* Pods-Demo-resources.sh */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.script.sh; path = "Pods-Demo-resources.sh"; sourceTree = ""; }; - 6D7C866C80CE2D736B5C8E1068EFCAE8 /* Pods_Demo.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; name = Pods_Demo.framework; path = "Pods-Demo.framework"; sourceTree = BUILT_PRODUCTS_DIR; }; + 6D7C866C80CE2D736B5C8E1068EFCAE8 /* Pods_Demo.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_Demo.framework; sourceTree = BUILT_PRODUCTS_DIR; }; 7A01701031823CCAC30B58767A21D8A4 /* Pods-Demo.modulemap */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = sourcecode.module; path = "Pods-Demo.modulemap"; sourceTree = ""; }; 9154BF16DC759A1EDD6A1AB4E22AA07D /* Pods-Demo-acknowledgements.markdown */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text; path = "Pods-Demo-acknowledgements.markdown"; sourceTree = ""; }; - 93A4A3777CF96A4AAC1D13BA6DCCEA73 /* Podfile */ = {isa = PBXFileReference; explicitFileType = text.script.ruby; includeInIndex = 1; lastKnownFileType = text; name = Podfile; path = ../Podfile; sourceTree = SOURCE_ROOT; xcLanguageSpecificationIdentifier = xcode.lang.ruby; }; + 93A4A3777CF96A4AAC1D13BA6DCCEA73 /* Podfile */ = {isa = PBXFileReference; explicitFileType = text.script.ruby; includeInIndex = 1; name = Podfile; path = ../Podfile; sourceTree = SOURCE_ROOT; xcLanguageSpecificationIdentifier = xcode.lang.ruby; }; A293EC6905CD2F770F31A1A57ACA0633 /* Pods-Demo.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; path = "Pods-Demo.debug.xcconfig"; sourceTree = ""; }; EB2BD00EE3F4FBA187EE15A5C9968F90 /* Pods-Demo-acknowledgements.plist */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.plist.xml; path = "Pods-Demo-acknowledgements.plist"; sourceTree = ""; }; /* End PBXFileReference section */ @@ -52,7 +52,6 @@ isa = PBXGroup; children = ( ); - name = SwiftLint; path = SwiftLint; sourceTree = ""; }; @@ -104,7 +103,6 @@ isa = PBXGroup; children = ( ); - name = SwiftFormat; path = SwiftFormat; sourceTree = ""; }; @@ -164,14 +162,15 @@ isa = PBXProject; attributes = { LastSwiftUpdateCheck = 0930; - LastUpgradeCheck = 0930; + LastUpgradeCheck = 1020; }; buildConfigurationList = 2D8E8EC45A3A1A1D94AE762CB5028504 /* Build configuration list for PBXProject "Pods" */; compatibilityVersion = "Xcode 3.2"; - developmentRegion = English; + developmentRegion = en; hasScannedForEncodings = 0; knownRegions = ( en, + Base, ); mainGroup = 7DB346D0F39D3F0E887471402A8071AB; productRefGroup = 075C9ABDED0D9A4A27285BB4F0D01753 /* Products */; @@ -199,6 +198,7 @@ isa = XCBuildConfiguration; buildSettings = { ALWAYS_SEARCH_USER_PATHS = NO; + CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES; CLANG_ANALYZER_NONNULL = YES; CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE; CLANG_CXX_LANGUAGE_STANDARD = "gnu++14"; @@ -329,6 +329,7 @@ isa = XCBuildConfiguration; buildSettings = { ALWAYS_SEARCH_USER_PATHS = NO; + CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES; CLANG_ANALYZER_NONNULL = YES; CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE; CLANG_CXX_LANGUAGE_STANDARD = "gnu++14"; From 4b824b370999fae762f8ba2bd07ba47c1bfd9d7a Mon Sep 17 00:00:00 2001 From: yoheimuta Date: Thu, 26 Sep 2019 12:41:06 +0900 Subject: [PATCH 4/7] refactor: Set VALID_ARCHS to inherited --- BufferedLogger.xcodeproj/project.pbxproj | 6 ++++-- Demo/Demo.xcodeproj/project.pbxproj | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/BufferedLogger.xcodeproj/project.pbxproj b/BufferedLogger.xcodeproj/project.pbxproj index 294cc1e..45c2b3d 100644 --- a/BufferedLogger.xcodeproj/project.pbxproj +++ b/BufferedLogger.xcodeproj/project.pbxproj @@ -337,6 +337,7 @@ SDKROOT = iphoneos; SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG; SWIFT_OPTIMIZATION_LEVEL = "-Onone"; + VALID_ARCHS = "$(inherited)"; VERSIONING_SYSTEM = "apple-generic"; VERSION_INFO_PREFIX = ""; }; @@ -392,6 +393,7 @@ SDKROOT = iphoneos; SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule"; VALIDATE_PRODUCT = YES; + VALID_ARCHS = "$(inherited)"; VERSIONING_SYSTEM = "apple-generic"; VERSION_INFO_PREFIX = ""; }; @@ -417,7 +419,7 @@ SWIFT_OPTIMIZATION_LEVEL = "-Onone"; SWIFT_VERSION = 5.0; TARGETED_DEVICE_FAMILY = "1,2"; - VALID_ARCHS = "arm64 armv7 armv7s x86_64 i386"; + VALID_ARCHS = "$(inherited)"; }; name = Debug; }; @@ -440,7 +442,7 @@ SKIP_INSTALL = YES; SWIFT_VERSION = 5.0; TARGETED_DEVICE_FAMILY = "1,2"; - VALID_ARCHS = "arm64 armv7 armv7s x86_64 i386"; + VALID_ARCHS = "$(inherited)"; }; name = Release; }; diff --git a/Demo/Demo.xcodeproj/project.pbxproj b/Demo/Demo.xcodeproj/project.pbxproj index be66192..8152dcb 100644 --- a/Demo/Demo.xcodeproj/project.pbxproj +++ b/Demo/Demo.xcodeproj/project.pbxproj @@ -292,6 +292,7 @@ SDKROOT = iphoneos; SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG; SWIFT_OPTIMIZATION_LEVEL = "-Onone"; + VALID_ARCHS = "$(inherited)"; }; name = Debug; }; @@ -344,6 +345,7 @@ SDKROOT = iphoneos; SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule"; VALIDATE_PRODUCT = YES; + VALID_ARCHS = "$(inherited)"; }; name = Release; }; From bae9e09c2706d36eed04880312b0b36987779654 Mon Sep 17 00:00:00 2001 From: yoheimuta Date: Thu, 26 Sep 2019 12:42:31 +0900 Subject: [PATCH 5/7] chore: Update README --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index a78314d..79bb6e5 100644 --- a/README.md +++ b/README.md @@ -2,7 +2,7 @@ [![Build Status](https://app.bitrise.io/app/75f1a12b7326ea09/status.svg?token=-Wus-j9Iq8IVKcFB3wLhSg&branch=master)](https://app.bitrise.io/app/75f1a12b7326ea09) [![Carthage compatible](https://img.shields.io/badge/Carthage-compatible-4BC51D.svg?style=flat)](https://github.com/Carthage/Carthage) -Language Swift 4 +Language Swift 5 BufferedLogger is a tiny but thread-safe logger with a buffering and retrying mechanism for iOS. @@ -18,7 +18,7 @@ You can use this framework... ## Runtime Requirements - iOS 9.0 or later -- Xcode 9.x - Swift4 +- Swift5 ## Installation From 72466ac71536e9f310b2430577707adbe3e7eecb Mon Sep 17 00:00:00 2001 From: yoheimuta Date: Thu, 26 Sep 2019 12:43:14 +0900 Subject: [PATCH 6/7] chore: Add Contributing --- README.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/README.md b/README.md index 79bb6e5..c214761 100644 --- a/README.md +++ b/README.md @@ -121,6 +121,18 @@ You can also define your own custom log entry storage backed by any storage syst See the EntryStroage protocol for more details. +## Contributing + +- Fork it +- Create your feature branch: git checkout -b your-new-feature +- Commit changes: git commit -m 'Add your feature' +- Push to the branch: git push origin your-new-feature +- Submit a pull request + +## License + +The MIT License (MIT) + # Acknowledgement Thank you to the Puree-Swift: https://github.com/cookpad/Puree-Swift From 7dfd92b9f35bcb106abca6f73bc2855ad972ac60 Mon Sep 17 00:00:00 2001 From: yoheimuta Date: Thu, 26 Sep 2019 12:50:56 +0900 Subject: [PATCH 7/7] tests: Optimized bitrise.yml --- bitrise.yml | 26 +------------------------- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git a/bitrise.yml b/bitrise.yml index 3a8c2d3..ae09018 100644 --- a/bitrise.yml +++ b/bitrise.yml @@ -3,32 +3,11 @@ format_version: '5' default_step_lib_source: https://github.com/bitrise-io/bitrise-steplib.git project_type: ios trigger_map: -- push_branch: "*" +- push_branch: master workflow: primary - pull_request_source_branch: "*" workflow: primary workflows: - deploy: - steps: - - activate-ssh-key@3.1.1: - run_if: '{{getenv "SSH_RSA_PRIVATE_KEY" | ne ""}}' - - git-clone@4.0.11: {} - - cache-pull@2.0.1: {} - - script@1.1.5: - title: Do anything with Script step - - certificate-and-profile-installer@1.9.3: {} - - cocoapods-install@1.7.2: {} - - xcode-test@1.18.14: - inputs: - - project_path: "$BITRISE_PROJECT_PATH" - - scheme: "$BITRISE_SCHEME" - - xcode-archive@2.4.8: - inputs: - - project_path: "$BITRISE_PROJECT_PATH" - - scheme: "$BITRISE_SCHEME" - - export_method: "$BITRISE_EXPORT_METHOD" - - deploy-to-bitrise-io@1.3.12: {} - - cache-push@2.0.5: {} primary: steps: - activate-ssh-key@3.1.1: @@ -53,6 +32,3 @@ app: - opts: is_expand: false BITRISE_SCHEME: BufferedLogger - - opts: - is_expand: false - BITRISE_EXPORT_METHOD: development