Remove term IO from Storage #112
Comments
yitsushi
added a commit
that referenced
this issue
Mar 27, 2024
In preparation for more work, related to #112, #37 and #8. - Migrated all tests to use testify's `Suite` instead of direct `assert` calls. - Simplified how the credentials file location is determined, now it's defined in one simple function. Changes I may revert: I hate string concatenation, it's just ugly in my eyes, so I may just add that linter to disabled and revert to `Sprintf`. I know it's more efficient, but not on this scale. Closes #8 References: - #8 - #37 - #112
yitsushi
added a commit
that referenced
this issue
Mar 27, 2024
In preparation for more work, related to #112, #37 and #8. - Migrated all tests to use testify's `Suite` instead of direct `assert` calls. - Simplified how the credentials file location is determined, now it's defined in one simple function. Changes I may revert: I hate string concatenation, it's just ugly in my eyes, so I may just add that linter to disabled and revert to `Sprintf`. I know it's more efficient, but not on this scale. Closes #8 References: - #8 - #37 - #112
yitsushi
added a commit
that referenced
this issue
Mar 27, 2024
In preparation for more work, related to #112, #37 and #8. - Migrated all tests to use testify's `Suite` instead of direct `assert` calls. - Simplified how the credentials file location is determined, now it's defined in one simple function. Changes I may revert: I hate string concatenation, it's just ugly in my eyes, so I may just add that linter to disabled and revert to `Sprintf`. I know it's more efficient, but not on this scale. Closes #8 References: - #8 - #37 - #112
yitsushi
added a commit
that referenced
this issue
Mar 27, 2024
In preparation for more work, related to #112, #37 and #8. - Migrated all tests to use testify's `Suite` instead of direct `assert` calls. - Simplified how the credentials file location is determined, now it's defined in one simple function. Changes I may revert: I hate string concatenation, it's just ugly in my eyes, so I may just add that linter to disabled and revert to `Sprintf`. I know it's more efficient, but not on this scale. Closes #8 References: - #8 - #37 - #112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Return error when we can't find the backend file, and handle the creation on cmd layer.
Reason: it's simply ugly and makes things harder. The storage layer should work with storage, asking for password is not their job.
The text was updated successfully, but these errors were encountered: