UI - Schedules - schedules types are not correctly displayed by UI

[brunetton]

Device

itead-sonoff-dual-r2

Version

1.18.0-gita518080a+github240830

Bug description

After changing event type (Disabled, Calendar, Relative) and come back again to the Schedule page, events types are all displayed as "Disabled"

Steps to reproduce

• goto Schedule page
• change one or more schedules types to "Relative"
• save changes
• reload UI (ctrl-R on browser)
• goto Schedule page again
• => all Schedules are displayed as "Disabled"

We can confirm that it's only a display problem using terminal. Using keys command we can check, for relative schedules:

> schType0 => "3"
> schType1 => "3"

That corresponds to definitions in code/espurna/scheduler.cpp:

enum class Type : int {
    Unknown = 0,
    Disabled,
    Calendar,
    Relative,
};

Build tools used

PlatformIO

Any relevant log output (when available)

No response

Decoded stack trace (when available)

No response

[mcspr]

The issue was that enumerations were sent as strings, ref. schedule 0 output. Internally, string input is converted back to enumeration. Not the other way around, though

pls check out current dev branch, I think the issue should be fixed there?
IndexedSettings here is key-prefix and a function to load key-prefix + index from settings and serialize it. Replacing output for webui lists may be helpful here, as every other place would prefer the string representation

espurna/code/espurna/scheduler.cpp

Lines 1533 to 1539 in fa5af86

	espurna::web::ws::EnumerableConfig config{root, STRING_VIEW("schConfig")};
	config.replacement(
	settings::internal::type,
	[](JsonArray& out, size_t index) {
	out.add(std::to_underlying(settings::type(index)));
	});
	config(STRING_VIEW("schedules"), settings::count(), settings::IndexedSettings);

Another change is UI now receives these as type pairs '[[number, string], [number, string], ...]' on load, so .html does not have to embed both description (at the top of the page) and the keys themselves (in the select / option)