Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assay classes to match PR #4 in dev-assay-class #166

Open
AlanSimmons opened this issue Nov 15, 2024 · 4 comments
Open

Update assay classes to match PR #4 in dev-assay-class #166

AlanSimmons opened this issue Nov 15, 2024 · 4 comments
Assignees

Comments

@AlanSimmons
Copy link
Collaborator

Reference

x-atlas-consortia/dev-assay-class-api#4 (comment)

@AlanSimmons
Copy link
Collaborator Author

AlanSimmons commented Nov 17, 2024

Changes

  1. HUBMAP:C004022/SENNET:C004022 term changed from "json-based" to "json_based".
  2. All references to vitessce_hint of "json-based" changed to "json_based".
  3. Added assay classification C202010 (derived salmon_rnaseq_10x json-based).
  4. Added vitessce_hint C202023 (segmentation_mask), with term separate from assaytype of segmentation-mask.
  5. Added vitessce_hints to assay classification C200370 (derived pas_ftu_segmentation).

@AlanSimmons AlanSimmons changed the title Update assay classes for Kaggle vitessce hints Update assay classes to match PR #4 in dev-assay-class Nov 18, 2024
@AlanSimmons
Copy link
Collaborator Author

Bug fix

The description concept scRNAseq (10x Genomics v3) was missing a concept ID. This is why the description was null for at least 2 assay classifications.

@AlanSimmons
Copy link
Collaborator Author

Update

Local instance of UBKG neo4j appears to align with latest assayclasses.json.

@AlanSimmons
Copy link
Collaborator Author

Additional corrections to dir-schema to match changes made to assayclasses.json

  • C202040 (DCWG scRNAseq-with-probes): changed dir-schema from rnaseq-with-probes-v to rnaseq-with-probes-v2.

  • C202020 (EPIC dataset segmentation mask) - changed dir-schema from segmentation-mask-v to segmentation-mask-v2

  • C202050 (DCWG xenium) - changed dir-schema from xenium-v to xenium-v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant