Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.18 - Enhancements related to clearing the data #7175

Open
piotrbak opened this issue Dec 10, 2024 · 3 comments · Fixed by #7110
Open

3.18 - Enhancements related to clearing the data #7175

piotrbak opened this issue Dec 10, 2024 · 3 comments · Fixed by #7110
Assignees
Labels
type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Milestone

Comments

@piotrbak
Copy link
Contributor

piotrbak commented Dec 10, 2024

User Story
As a user, I’d like to preserve fonts files while clearing Google Fonts data

Acceptance Criteria

  • When triggering rocket_clean_domain we should only clear CSS related to the Google Fonts (/wp-content/cache/fonts/{site_id}/google-fonts/css/)
  • The font files itselves should be preserved while triggering the rocket_clean_domain (/wp-content/cache/fonts/{site_id}/google-fonts/fonts)
  • When switching the theme we should clear both CSS files and font files
  • When the domain is changed and the button is clicked, we need to make sure that the CSS and font files are erased
  • All the above scenarios should be multisite compatible. It means that we should be erasing only the data related to the specific website while triggering those actions

Additional information

  • The font file size in woff2 format is around 10-40kb, it's pretty safe to keep them for a longer time in the filesystem, at least for now
  • The time for download each font is around 0.12 seconds
  • Adding 2 fonts using built-in Astra theme features adds 14 Google Font files, which adds more than 1.5s of processing of uncached page
  • Adding 14 complete fonts using Google website added 425 Google Font files, which added more than 40s of processing of uncached page

Schedule

  • The target to implement this enhancement is 3.18 release itself, or 3rd alpha release
@piotrbak piotrbak added the type: enhancement Improvements that slightly enhance existing functionality and are fast to implement label Dec 10, 2024
@piotrbak piotrbak added this to the 3.18 milestone Dec 10, 2024
@remyperona
Copy link
Contributor

What do you mean by rocket_clean_data? It's not an existing function/action

@piotrbak
Copy link
Contributor Author

Already edited it for the correct naming, sorry, my bad

@remyperona remyperona self-assigned this Dec 10, 2024
@remyperona remyperona linked a pull request Dec 10, 2024 that will close this issue
7 tasks
@Mai-Saad
Copy link
Contributor

working fine on related PR knowing that domain change is out of scope from test on multisite as now the banner is not displayed there even on 3.17.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants