Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintaining the client #2

Open
srikwit opened this issue Mar 16, 2020 · 4 comments
Open

Maintaining the client #2

srikwit opened this issue Mar 16, 2020 · 4 comments

Comments

@srikwit
Copy link

srikwit commented Mar 16, 2020

Hi,

Do you have any plans for maintaining this nsqueue client?
This is listed in the official list of clients at: https://nsq.io/clients/client_libraries.html

It can be migrated to support a more recent version of Rust.
Please let me know if you would need some help in doing so.

@wisespace-io
Copy link
Owner

wisespace-io commented Mar 17, 2020

@srikwit This client has been based on earlier version of Tokio. Since then the Tokio library has evolved a lot. It will demand some time to update but it can be done. It can be a good exercise to learn the new async features added to Rust. Help is welcome.

@srikwit
Copy link
Author

srikwit commented Mar 17, 2020

@wisespace-io Yes, I can take this up. I have been able to migrate a previous library based on tokio-core to the current tokio crate. I will be able to push changes by this weekend. Please do help me out in case of issues.

@srikwit
Copy link
Author

srikwit commented Mar 22, 2020

@wisespace-io I have been able to migrate most code to nightly, down to 18 errors mostly around the futures crate. Might need a few days before I can send them for your review.

@wisespace-io
Copy link
Owner

@srikwit Ok, I imagined that it would take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants