Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add version checks to relevant offline commands #70

Open
Ladicek opened this issue Feb 19, 2016 · 3 comments
Open

add version checks to relevant offline commands #70

Ladicek opened this issue Feb 19, 2016 · 3 comments

Comments

@Ladicek
Copy link
Contributor

Ladicek commented Feb 19, 2016

Some offline commands are version-specific and should have version checks. This wasn't possible before, but now that offline version discovery is implemented, we should add the checks retroactively.
@Ladicek Ladicek mentioned this issue Feb 19, 2016
Merged
@Ladicek
Copy link
Contributor Author

Ladicek commented Feb 19, 2016

I think I spoke with @olukas about that. There might be other people who contributed commands with missing version checks in offline command. I will need to review that.

@olukas
Copy link
Collaborator

olukas commented Feb 19, 2016

I will add version checkers into my security-related offline commands.

@Ladicek
Copy link
Contributor Author

Ladicek commented Feb 19, 2016

Thanks :-)

@Ladicek Ladicek mentioned this issue Feb 19, 2016
Merged
olukas pushed a commit to olukas/creaper that referenced this issue Mar 17, 2017
@OndrejKotek
Merge pull request wildfly-extras#70 from OndrejKotek/elytron
38da0e6 
Adding certificate-revocation-list to Elytron trust-managers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ladicek @olukas