Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeouts in OnlineOptions are in millis #143

Open
Ladicek opened this issue Oct 5, 2016 · 1 comment
Open

timeouts in OnlineOptions are in millis #143

Ladicek opened this issue Oct 5, 2016 · 1 comment
Milestone

Comments

@Ladicek
Copy link
Contributor

Ladicek commented Oct 5, 2016

For historical reasons, timeouts in the OnlineOptions class are expected to be provided in milliseconds. Everywhere else (Administration etc.), we use seconds, as that is much more human-friendly.

We should change the OnlineOptions class to accept seconds as well. This would of course be backwards incompatible, so can only be done in 2.0.

@Ladicek Ladicek added this to the 2.0.0 milestone Oct 5, 2016
@Ladicek
Copy link
Contributor Author

Ladicek commented Oct 5, 2016

If at all possible, old methods that accept millis should be kept and deprecated, while new methods should be added. That way, it could be done before 2.0. But I'm not sure if it's feasible, so for now, I'm keeping the 2.0.0 milestone.

@simkam simkam modified the milestones: 2.0.0, 3.0.0 Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants