Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] change repo name to webcompat-metrics-client #36

Closed
miketaylr opened this issue Apr 11, 2018 · 12 comments
Closed

[proposal] change repo name to webcompat-metrics-client #36

miketaylr opened this issue Apr 11, 2018 · 12 comments

Comments

@miketaylr
Copy link
Member

I'd like to do the following:

  1. rename this repo to webcompat-metrics-client
  2. create a new repo webcompat-metrics-server to power the API for the client
  3. replace the existing dummy data with the metrics-server output (1b30338)

I'd like @karlcow to build the webcompat-metrics-server to serve the initial needsdiagnosis data (and whatever we need to serve in the future)

Thoughts @karlcow @magsout?

@karlcow
Copy link
Member

karlcow commented Apr 11, 2018

Having a separate repo will help decouple the client and the server.
It will make it less likely to have a very high dependency in between the data set and the way we show them to the world.

It also allows the possibility for other clients/consumers.

  • webcompat-metrics-client
  • a CLI client for people who would like to access data into their terminal or their own UI
  • webcompat.com can benefit of it too by having ways to pull the data into any UI where it would be useful.

Some of our data are dynamics (latest needsdiagnosis total number) but some are static history of the needsdiagnosis total number.

In addition, the server has two components:

  1. Expose the data through an HTTP API
  2. Collect through cron scripts (probably?) some of the data into the backend for the static data.

It also makes it easier for @magsout to focus on the client without being pulled into the API development. There will be probably initial coordination on how to consume the data and which type of documentation/navigated inserted in the HTTP API responses or out-of-band with hard-coded URLs and versioning.

@magsout
Copy link
Member

magsout commented Apr 12, 2018

I agree with both of you. I have talked with you (email + irc) and I think it's a good thing.

@magsout
Copy link
Member

magsout commented Apr 13, 2018

@miketaylr what next?

  • rename this repo to webcompat-metrics-client
  • remove all node files on this repo?
  • made this repo only for the client?

@karlcow
Copy link
Member

karlcow commented Apr 15, 2018

@miketaylr @magsout Created https://github.com/webcompat/webcompat-metrics-server

  • Keep the current fake server in webcompat-metrics-client (if it helps you develop the client) Just the time that there is an instance up in the air for webcompat-metrics-server

@miketaylr
Copy link
Member Author

rename this repo to webcompat-metrics-client

Yeah, we can do this now. I think let's wait for @karlcow to have something functional that serves the data you need before moving forward with removing anything else server related.

@karlcow
Copy link
Member

karlcow commented Apr 26, 2018

You can change the name. :)

@magsout
Copy link
Member

magsout commented Apr 27, 2018

I let @miketaylr doing it

@miketaylr
Copy link
Member Author

I let @miketaylr doing it

OK! Just did that, thanks for letting me feel useful.

@miketaylr
Copy link
Member Author

So, we can close here? Maybe open an issue to remove the mock data once @karlcow's server is up and running?

@magsout
Copy link
Member

magsout commented Apr 27, 2018

@miketaylr I’m going to open a PR because I added this endpoint webcompat/webcompat-metrics-server#7 in the dev serv of the client

@magsout
Copy link
Member

magsout commented Apr 27, 2018

@miketaylr when do you think is appropriate to remove the codebase of the server, clean and update documentation? Waiting the server is running at some point, or the temporary endpoint is enought?

@miketaylr
Copy link
Member Author

temporary endpoint is enought?

This seems fine to me! Basically, whenever you feel like it.

magsout added a commit that referenced this issue May 8, 2018
magsout added a commit that referenced this issue May 8, 2018
magsout added a commit that referenced this issue May 8, 2018
magsout added a commit that referenced this issue May 8, 2018
@magsout magsout closed this as completed in 77dcf58 May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants