Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go Mod: v2 tag #7

Closed
TheMarstonConnell opened this issue Oct 28, 2023 · 1 comment
Closed

Go Mod: v2 tag #7

TheMarstonConnell opened this issue Oct 28, 2023 · 1 comment

Comments

@TheMarstonConnell
Copy link
Contributor

Current if I try to import the newest release (v2.5.0), the module version doesn't match the tag's major version number. Either the projects package name needs to be changed from github.com/wealdtech/go-merkletree to github.com/wealdtech/go-merkletree/v2 or the entire project needs to be cloned into a v2 folder inside the project for some backwards compatibility. I'm in favour of the first option as github does a pretty good job of managing old tags.
@TheMarstonConnell TheMarstonConnell mentioned this issue Nov 1, 2023
Merged
@mcdee
Copy link
Collaborator

mcdee commented Nov 6, 2023

Addressed in #8

@mcdee mcdee closed this as completed Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcdee @TheMarstonConnell