Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading naming about brightness #8

Open
KiritaniAyaka opened this issue Oct 14, 2024 · 1 comment
Open

Misleading naming about brightness #8

KiritaniAyaka opened this issue Oct 14, 2024 · 1 comment

Comments

@KiritaniAyaka
Copy link
Contributor

根据此处代码的注释,brightness 的算法来源于 W3C 文档,因此代码中的 brightness 应该指的是感知亮度(perceived brightness),而不是 HSB 中的明度(brightness)。

虽然 colorsea 使用的是 HSV 而不是 HSB,但在文档里没找到获取 value 的方法,容易让人以为 brightness 就是 HSB 中的 brightness

建议给 HSV 色彩空间中的 Value 添加获取和设置的方法,同时在文档中标注此处 brightness 是感知亮度(代码中的文档注释似乎也需要修改一下格式,VS Code 里不能正常渲染)

image

@waterbeside
Copy link
Owner

谢谢反馈,后续我会处理。
谢谢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants