Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to make it possible to use with Boot #7

Open
nha opened this issue Mar 9, 2017 · 4 comments
Open

Refactor code to make it possible to use with Boot #7

nha opened this issue Mar 9, 2017 · 4 comments

Comments

@nha
Copy link

nha commented Mar 9, 2017

I get this is a leiningen task.

I am sure there are people using boot that would be interested (I am one).

This project could either provide a boot task, or expose functions that a boot task could use to render the graph, prune dependencies etc.

@hlship
Copy link
Member

hlship commented Mar 9, 2017

It's possible a bit of it could be rewritten to use pomengranate (the underlying wrapper around the Aether/Maven code) more directly; that would make it more reasonable to have Boot make use of the code. To be honest, it's a bit of a hack getting the dependencies, especially the full dependency tree.

@hlship hlship changed the title boot support or expose functions Refactor code to make it possible to use with Boot Mar 9, 2017
@hlship
Copy link
Member

hlship commented Mar 9, 2017

There's also a few other things related to logging that are a bit Leiningen specific but that could be refactored (we pass around an options map everywhere, logging could be abstracted to functions added to the options map).

@nha
Copy link
Author

nha commented Mar 9, 2017

So maybe steps towards boot compatibility would be:

  • exposing a function that takes dependencies in a format vizdeps likes and returns an image file (or takes a path/file as parameter). This would make it usable from clojure code as a library, and therefore by boot down the road.

  • providing a helper function that would go from (:dependencies pod/env) to the format you want, and maybe even a boot task using it. This would make it "batteries incuded" for boot users.

For context, I know boot has some facilities around dependencies like

Note: I did not dig into the vizdep code yet so it may not all make sense - or make sense at all.
In any case 👍 for doing it - I was wishing for something like that.

@hlship
Copy link
Member

hlship commented Feb 8, 2020

I don't use Boot any more (I tend to use Joker where in the past I used Boot). I'm open to a reasonable PR to break the code up to be more easily leveraged by Boot, but don't have the bandwidth to do the work itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants