Allow supplying custom profiles #16
Comments
MIJOTHY
added a commit
to MIJOTHY/vizdeps
that referenced
this issue
Feb 19, 2021
Currently the only supported profiles in the `vizdeps` command are `:user` and `:dev`. `leiningen` allows arbitrary profiles to be created and to have custom dependencies (and other fields) defined for those profiles. This commit ----------- Adds a `-P | --profiles` parameter, expecting a comma-delimited string of profile names. These profiles will then be used in dependency calculation. Relates to ---------- walmartlabs/issues/16
MIJOTHY
added a commit
to MIJOTHY/vizdeps
that referenced
this issue
Feb 19, 2021
Currently the only supported profiles in the `vizdeps` command are `:user` and `:dev`. `leiningen` allows arbitrary profiles to be created and to have custom dependencies (and other fields) defined for those profiles. This commit ----------- Adds a `-P | --profiles` parameter, expecting a comma-delimited string of profile names. These profiles will then be used in dependency calculation. The `-d | --dev` flag is removed as its functionality is superseded by `-P | --profiles`. Note that this is a _BREAKING_ change, due to the removal of the `-d` flag. Relates to ---------- walmartlabs/issues/16
MIJOTHY
added a commit
to MIJOTHY/vizdeps
that referenced
this issue
Feb 19, 2021
Currently the only supported profiles in the `vizdeps` command are `:user` and `:dev`. `leiningen` allows arbitrary profiles to be created and to have custom dependencies (and other fields) defined for those profiles. This commit ----------- Adds a `-P | --profiles` parameter, expecting a comma-delimited string of profile names. These profiles will then be used in dependency calculation. The `-d | --dev` flag is removed as its functionality is superseded by `-P | --profiles`. Note that this is a _BREAKING_ change, due to the removal of the `-d` flag. Relates to ---------- walmartlabs#16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like the set of profiles used in dependency calculation hard-codes the profile being used:
vizdeps/src/leiningen/vizdeps.clj
Lines 218 to 220 in e106df5
It would be useful if consumers could supply profiles, either via the usual
lein with-profiles foo <command>syntax or through a command line argument.Happy to submit a PR.
The text was updated successfully, but these errors were encountered: