From ccfee5215c678ba4715534348546975e2b5afd2d Mon Sep 17 00:00:00 2001 From: Andrew Burger Date: Thu, 14 Nov 2024 17:57:51 +0100 Subject: [PATCH] refactoring todos --- substrate/primitives/application-crypto/src/bls381.rs | 6 ++---- substrate/primitives/application-crypto/src/ecdsa_bls381.rs | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/substrate/primitives/application-crypto/src/bls381.rs b/substrate/primitives/application-crypto/src/bls381.rs index 3d5dbbf63d59..d08a50d428aa 100644 --- a/substrate/primitives/application-crypto/src/bls381.rs +++ b/substrate/primitives/application-crypto/src/bls381.rs @@ -56,10 +56,8 @@ impl RuntimePublic for Public { } fn generate_pop(&mut self, key_type: KeyTypeId) -> Option { - let pub_key_as_bytes = self.to_raw_vec(); - let pop_context_tag: &[u8] = b"POP_"; - let pop_statement = [pop_context_tag, pub_key_as_bytes.as_slice()].concat(); - sp_io::crypto::bls381_sign(key_type, self, pop_statement.as_slice()) + // TODO: Add host function + // sp_io::crypto::generate_pop() } fn verify_pop(&self, pop: &Self::Signature) -> bool { diff --git a/substrate/primitives/application-crypto/src/ecdsa_bls381.rs b/substrate/primitives/application-crypto/src/ecdsa_bls381.rs index 9c8864e3dbdf..a2d2f852b4f8 100644 --- a/substrate/primitives/application-crypto/src/ecdsa_bls381.rs +++ b/substrate/primitives/application-crypto/src/ecdsa_bls381.rs @@ -53,7 +53,7 @@ impl RuntimePublic for Public { } fn generate_pop(&mut self, key_type: KeyTypeId) -> Option { - // TODO: Implement Special Case + // TODO: Implement Special Case by calling both pop generations None }