Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test suite doesn't pass with python 3.10 #4392

Open
cyberthirst opened this issue Dec 10, 2024 · 1 comment
Open

test suite doesn't pass with python 3.10 #4392

cyberthirst opened this issue Dec 10, 2024 · 1 comment
Labels
needs triage needs triage

Comments

@cyberthirst
Copy link
Collaborator

Version Information

  • vyper Version (output of vyper --version): 0.4.1b2+commit.5ff57c53a
  • OS: osx/linux/win
  • Python Version (output of python --version): 3.10

What's your issue about?

The test suite doesn't pass with python 3.10 although it's a supported version

I noticed this atleast for

return int.from_bytes(_strict_slice(payload, ofst, 32))

for 3.10 byteorder for from_bytes doesn't have a default value: https://docs.python.org/3.10/library/stdtypes.html#int.from_bytes

@cyberthirst cyberthirst added the needs triage needs triage label Dec 10, 2024
@charles-cooper
Copy link
Member

nice find. also, see https://devguide.python.org/versions/, we can probably follow this as to when to retire older python versions (although in the past we have been a bit more aggressive about dropping older versions, especially when upgrading to python3.10 for match/case support).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage needs triage
Projects
None yet
Development

No branches or pull requests

2 participants