Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Changing assets in assets/favicons/ doesn't change icon on homepage #34

Open
neotamias opened this issue Feb 17, 2021 · 5 comments

Comments

@neotamias
Copy link
Contributor

image
Icons are changed inside assets/favicons/

image
website doesn't change

image
built fine and it is loading as the favicon the browser is loading has changed

@vsoch
Copy link
Owner

vsoch commented Feb 17, 2021

The icon on the home page is not derived from the favicon, it's the logo.svg file in includes, linked here https://github.com/vsoch/docsy-jekyll/blob/master/_includes/header.html#L4.

@neotamias
Copy link
Contributor Author

thank you! can you add that to the instructions?

@vsoch
Copy link
Owner

vsoch commented Feb 17, 2021

Would you care to contribute a PR to add it?

@neotamias
Copy link
Contributor Author

i can do that for sure

@vsoch
Copy link
Owner

vsoch commented Mar 30, 2021

@neotamias did you plan to contribute here or should we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants