From 7fc7813aa49acb0998645114f1bb49ed102e9311 Mon Sep 17 00:00:00 2001 From: Isabela Guimaraes Date: Thu, 19 Dec 2024 13:22:19 -0800 Subject: [PATCH 1/2] adding data-testid to mandatory GKE elements for e2e tests locators Signed-off-by: Isabela Guimaraes --- pkg/gke/components/CruGKE.vue | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/gke/components/CruGKE.vue b/pkg/gke/components/CruGKE.vue index 59bfd160127..714ffe3c4b2 100644 --- a/pkg/gke/components/CruGKE.vue +++ b/pkg/gke/components/CruGKE.vue @@ -705,6 +705,7 @@ export default defineComponent({ required :rules="fvGetAndReportPathRules('clusterName')" @update:value="setClusterName" + data-testid="gke-cluster-name" />
@@ -714,6 +715,7 @@ export default defineComponent({ label-key="nameNsDescription.description.label" :placeholder="t('nameNsDescription.description.placeholder')" @update:value="setClusterDescription" + data-testid="gke-cluster-description" />
From 4cfd15a1f01af1e78b14976faccb6a81d16352f6 Mon Sep 17 00:00:00 2001 From: Isabela Guimaraes Date: Thu, 19 Dec 2024 13:44:00 -0800 Subject: [PATCH 2/2] changed order of data-testid to fix eslint error Signed-off-by: Isabela Guimaraes --- pkg/gke/components/CruGKE.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/gke/components/CruGKE.vue b/pkg/gke/components/CruGKE.vue index 714ffe3c4b2..2ea85145e4c 100644 --- a/pkg/gke/components/CruGKE.vue +++ b/pkg/gke/components/CruGKE.vue @@ -704,8 +704,8 @@ export default defineComponent({ label-key="generic.name" required :rules="fvGetAndReportPathRules('clusterName')" - @update:value="setClusterName" data-testid="gke-cluster-name" + @update:value="setClusterName" />
@@ -714,8 +714,8 @@ export default defineComponent({ :mode="mode" label-key="nameNsDescription.description.label" :placeholder="t('nameNsDescription.description.placeholder')" - @update:value="setClusterDescription" data-testid="gke-cluster-description" + @update:value="setClusterDescription" />