You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, "volo add EaselJS" pulls the master branch, even though tags are available, because the tags have a somewhat unusual format; https://github.com/CreateJS/EaselJS/tags has examples. It strikes me as reasonable to include "prepended with release_v" into the heuristic that's currently used.
The text was updated successfully, but these errors were encountered:
This goes against the usual git/hub convention of 'vX.X.X' or just 'X.X.X'. Someone else may have a 'rel_v' or some other weird prefix, and I'm reticent to add more since it also increases the likelihood of false positives for version tags when they are just branches (git flow release branches come to mind?). I would instead encourage the developer to use more standardized tag names.
In the meantime, a fixed version volojs/repos package.json override could be used.
Agreed, there are indeed other ways around this issue. My thinking in suggesting this was more that it struck me as wildly unlikely that "release_vX.X.X" would be intended to mean something semantically different than "vX.X.X", so that the chances of false positives would be vanishingly small.
What about Three.js using r49, etc for their tagging strategy? The list could go on forever. I have been writing something similar to pull down a repo version based on github tags and it is has been very difficult based on all these different tagging strategies. Wouldn't it be nice if the community would be more consistent :- )
Right now, "volo add EaselJS" pulls the master branch, even though tags are available, because the tags have a somewhat unusual format; https://github.com/CreateJS/EaselJS/tags has examples. It strikes me as reasonable to include "prepended with release_v" into the heuristic that's currently used.
The text was updated successfully, but these errors were encountered: