Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version information is inconsistent #645

Open
J-A-U opened this issue Apr 4, 2024 · 2 comments
Open

Version information is inconsistent #645

J-A-U opened this issue Apr 4, 2024 · 2 comments

Comments

@J-A-U
Copy link
Collaborator

J-A-U commented Apr 4, 2024

Vzlogger doesn't identify itself in the same way, even tho the builds should be from similar sourcecode.

Binary from cloudsmith:

pi@pi:~ $ vzlogger -V
0.8.4
 based on git version: GIT-NOTFOUND
 last commit date:

Local build:

pi@pi:~ $ ./vzlogger/build/src/vzlogger -V
0.8.3
 based on git version: tags/v0.8.4-0-ga56f6281fc
 last commit date: Tue, 2 Apr 2024 06:38:32 +0200
@r00t-
Copy link
Contributor

r00t- commented Apr 4, 2024

it's normally intended that public releases have just a version number, while git/developer builds have the git commit details.

the biggest immediate issue is see is that the git info should probably be omitted altogether rather than having "GIT-NOTFOUND" or an empty string.

if i got this right, the debian build process downloads and extracts a tarball, so the git info is simply not available, which is intentional.

@J-A-U
Copy link
Collaborator Author

J-A-U commented Apr 4, 2024

For the public release: Got it.

It's still strange the local build identifies as 0.8.3.

@J-A-U J-A-U added the Won't fix label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants