Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation progress indicator #41

Open
ssadjina opened this issue Aug 8, 2017 · 2 comments
Open

Simulation progress indicator #41

ssadjina opened this issue Aug 8, 2017 · 2 comments
Labels

Comments

@ssadjina
Copy link

ssadjina commented Aug 8, 2017

At least for some cases, the progress indicator during a simulation gives strange results. More precisely, it never reaches the final "95%" mark and, instead:

capture

This particular example was obtained with the following execution config file:
start 0 stop 8 step_size 1 comm_timeout_ms 100000 step_timeout_multiplier 1000 instantiation_timeout_ms 60000

In this example, this behavior is experienced up a total simulation time of 20s (again, with step size 1s):
start 0 stop 20 step_size 1

Scaling all the times by a factor of 0.1, however, causes the progress indicator to function as expected:
start 0 stop 2 step_size 0.1

I suspect a minor error in the caclulation of the progress indicator.

@ssadjina
Copy link
Author

ssadjina commented Aug 8, 2017

I seem to have missed my chance to assign correct labels for this issue. Be gentle, this is my first trip to GitHub ;)

@kyllingstad kyllingstad added the bug label Aug 8, 2017
@kyllingstad
Copy link
Member

kyllingstad commented Aug 8, 2017

For future reference, this is already registered in our old issue tracker as VIPROMA-118, with the following description:

[coralmaster] always prints its progress in increments of 5%. If the total number of time steps in a simulation is less than 20, this has the unfortunate consequence that 100% is never reached. The solution is to do something a bit more clever to the nextPerc variable in [src/master/main.cpp] than simply add 0.05 to it.

Thanks for posting it here! Label added. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants