Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard - Issue of Widget-Drop-Area #8473

Open
subIT1 opened this issue Jan 9, 2025 · 5 comments
Open

Dashboard - Issue of Widget-Drop-Area #8473

subIT1 opened this issue Jan 9, 2025 · 5 comments
Labels
documentation Improvements or additions to documentation vaadin-dashboard waiting for author Further information is requested

Comments

@subIT1
Copy link

subIT1 commented Jan 9, 2025

Description

When having the dashboard like in the image below - There are constellations where the drop-area does not appear. So there is enough space but the drop area does only appear when moving some widgets around.

image

Expected outcome

Every space where enough space for the widget exists should be droppable in each case and not after some other movements.

Minimal reproducible example

Website

Steps to reproduce

See the Image

Environment

Demo-Website

Browsers

Issue is not browser related

@subIT1
Copy link
Author

subIT1 commented Jan 9, 2025

@tomivirkki
Copy link
Member

The dashed light blue area is the position of the dragged widget in the dashboard, not a dropzone. You can drag the widget over the empty space and the widgets will reorder:

Kapture.2025-01-09.at.13.30.47.mp4

@rolfsmeds
Copy link
Contributor

I mean, technically I think that is the drop area for the widget currently being dragged, in the sense that if you let go of it it drops to where the dashed area is.

But I think what @subIT1 means is that he would want to move the widget to the empty area below the dotted box in his screenshot, which isn't possible with the layout model of the dashboard, which doesn't manage the specific column and row for each widget, but instead just defines the order of widgets, and lets css grid lay them out where they end up based on colspan and the current col count.

Switching to dense mode should fill that gap up automatically though.

@yuriy-fix yuriy-fix added documentation Improvements or additions to documentation vaadin-dashboard waiting for author Further information is requested labels Jan 9, 2025
@rolfsmeds
Copy link
Contributor

As you can see in @tomivirkki's video, what happens is that the "Visitors by month" widget moves to the place left empty by "A kittykat" when you move the latter on top of another widget in order to take its place in the widget-order.

It would be nice if the dashboard could show a drop area in the empty space, of course (which presumably would require somehow generating elements to fill empty spaces), but the same reshuffling would still take place when you drop, because there's now an empty space to fill.

@subITCSS
Copy link

subITCSS commented Jan 9, 2025

I mean, technically I think that is the drop area for the widget currently being dragged, in the sense that if you let go of it it drops to where the dashed area is.

But I think what @subIT1 means is that he would want to move the widget to the empty area below the dotted box in his screenshot, which isn't possible with the layout model of the dashboard, which doesn't manage the specific column and row for each widget, but instead just defines the order of widgets, and lets css grid lay them out where they end up based on colspan and the current col count.

Switching to dense mode should fill that gap up automatically though.

Right so i moved the "A kittykat!" and i wanted to place it where the "empty-papce" is. But based on the drop-Area i only could place it to it drag-area where it was before.
Additionally when some Widgets around are moved and the same Slot with the "empty-space" exists, then it is possible and there is a mark of the drop-area and the drag-area (which was the "empty-space").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation vaadin-dashboard waiting for author Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants