From bd5872ba96b5273cac736463dadb0fae593e6fbb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20=C5=9Alusarczyk?= Date: Wed, 8 Jan 2025 11:38:03 +0100 Subject: [PATCH 1/4] removed unused variables --- include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h b/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h index 3c7eb21607..d90ceff5fc 100644 --- a/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h +++ b/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h @@ -489,8 +489,6 @@ struct __parallel_transform_scan_static_single_group_submitter<_Inclusive, _Elem const auto& __subgroup = __self_item.get_sub_group(); // This kernel is only launched for sizes less than 2^16 const ::std::uint16_t __item_id = __self_item.get_local_linear_id(); - const ::std::uint16_t __subgroup_id = __subgroup.get_group_id(); - const ::std::uint16_t __subgroup_size = __subgroup.get_local_linear_range(); auto __lacc_ptr = __dpl_sycl::__get_accessor_ptr(__lacc); for (std::uint16_t __idx = __item_id; __idx < __n; __idx += _WGSize) @@ -562,8 +560,6 @@ struct __parallel_copy_if_static_single_group_submitter<_Size, _ElemsPerItem, _W const auto& __subgroup = __self_item.get_sub_group(); // This kernel is only launched for sizes less than 2^16 const ::std::uint16_t __item_id = __self_item.get_local_linear_id(); - const ::std::uint16_t __subgroup_id = __subgroup.get_group_id(); - const ::std::uint16_t __subgroup_size = __subgroup.get_local_linear_range(); auto __lacc_ptr = __dpl_sycl::__get_accessor_ptr(__lacc); for (std::uint16_t __idx = __item_id; __idx < __n; __idx += _WGSize) { From 660f3666d8c5bf750c74c6af37d44ecc28e42d32 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20=C5=9Alusarczyk?= Date: Wed, 8 Jan 2025 13:44:07 +0100 Subject: [PATCH 2/4] yet another unused variable --- include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h b/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h index d90ceff5fc..7265403c40 100644 --- a/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h +++ b/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h @@ -486,7 +486,6 @@ struct __parallel_transform_scan_static_single_group_submitter<_Inclusive, _Elem __hdl.parallel_for<_ScanKernelName...>( sycl::nd_range<1>(_WGSize, _WGSize), [=](sycl::nd_item<1> __self_item) { const auto& __group = __self_item.get_group(); - const auto& __subgroup = __self_item.get_sub_group(); // This kernel is only launched for sizes less than 2^16 const ::std::uint16_t __item_id = __self_item.get_local_linear_id(); @@ -557,7 +556,6 @@ struct __parallel_copy_if_static_single_group_submitter<_Size, _ElemsPerItem, _W sycl::nd_range<1>(_WGSize, _WGSize), [=](sycl::nd_item<1> __self_item) { auto __res_ptr = __result_and_scratch_storage_t::__get_usm_or_buffer_accessor_ptr(__res_acc); const auto& __group = __self_item.get_group(); - const auto& __subgroup = __self_item.get_sub_group(); // This kernel is only launched for sizes less than 2^16 const ::std::uint16_t __item_id = __self_item.get_local_linear_id(); auto __lacc_ptr = __dpl_sycl::__get_accessor_ptr(__lacc); From 8d6b6a661cd77060e60dc596b5961dca2f03069a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20=C5=9Alusarczyk?= Date: Wed, 8 Jan 2025 13:47:20 +0100 Subject: [PATCH 3/4] unsued types --- include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h b/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h index 7265403c40..7e38c1c4c3 100644 --- a/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h +++ b/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h @@ -2431,8 +2431,6 @@ __parallel_reduce_by_segment(oneapi::dpl::__internal::__device_backend_tag, _Exe const auto __n = __keys.size(); - using __diff_type = oneapi::dpl::__internal::__difference_t<_Range1>; - using __key_type = oneapi::dpl::__internal::__value_t<_Range1>; using __val_type = oneapi::dpl::__internal::__value_t<_Range2>; // Prior to icpx 2025.0, the reduce-then-scan path performs poorly and should be avoided. #if !defined(__INTEL_LLVM_COMPILER) || __INTEL_LLVM_COMPILER >= 20250000 From c97f441d237d972f8bda099b58a99d734d28a72d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20=C5=9Alusarczyk?= Date: Wed, 8 Jan 2025 13:49:45 +0100 Subject: [PATCH 4/4] removed more unused types --- .../dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge.h b/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge.h index 36860f2d44..b1a775dd8f 100644 --- a/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge.h +++ b/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge.h @@ -227,11 +227,6 @@ struct __parallel_merge_submitter_large<_IdType, _CustomName, nd_range_params eval_nd_range_params(_ExecutionPolicy&& __exec, const _Range1& __rng1, const _Range2& __rng2) const { - using _Range1ValueType = oneapi::dpl::__internal::__value_t<_Range1>; - using _Range2ValueType = oneapi::dpl::__internal::__value_t<_Range2>; - using _RangeValueType = std::conditional_t<(sizeof(_Range1ValueType) > sizeof(_Range2ValueType)), - _Range1ValueType, _Range2ValueType>; - const std::size_t __n = __rng1.size() + __rng2.size(); // Empirical number of values to process per work-item