fails for Mocha #3
Comments
|
so sorry for the late reply, I was out with a bad cold for a couple of weeks. I'll address this ASAP. thanks for the issue edit: btw, thanks for the suggestions as well. We'll make those changes. It's awesome that you're looking to use this with mocha, I'm sorry I wasn't able to get this taken care of faster. |
|
no rush; I'm well-acquainted with providing free support and bug fixes for software 😄 |
|
@boneskull I updated The error should be gone if you reinstall and run I'll leave this open to address the other suggestions. We'll probably create individual issues around those and then we can close this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Wanted to get this into our publishing workflow, but ran into varied difficulties.
First problem is that there's something weird going on in either
repo-utils,expand-pkg, orparse-git-config. Was trying to fix this, but onceparse-git-configgiving me problems, I crawled back out of the rabbit hole.To reproduce badness:
npm install -g update update-contributorsupdate init, choosecontributorsupdatein mocha working copyMocha's
package.jsonhas a stringhomepagevalue and an objectrepositoryvalue.I tracked the problem to the weirdness happening in
lib/expanders/git.jsofexpand-pkg:I'm not sure why we're looking at
config.repositoryand then expandingconfig.homepage. The intent of this function is unclear. To convince myself I was sane, I created a failing test:Anyhow, there were a bunch of other failing tests here, because of problems in
parse-git-configand its ilk. Here are some:1) expand-pkg (no git repository) owner should get owner from the git url: AssertionError: 'Christopher%20Hiller' == 'Christopher Hiller' + expected - actual -Christopher%20Hiller +Christopher Hiller at Context.<anonymous> (test/test-no-git.js:271:14) 2) expand (no package.json) homepage should add a homepage from git repository: AssertionError: 'https://github.com/Christopher%20Hiller/project-no-package' == 'https://github.com/jonschlinkert/project-no-package' + expected - actual -https://github.com/Christopher%20Hiller/project-no-package +https://github.com/jonschlinkert/project-no-package at Context.<anonymous> (test/test-no-package.js:275:14) at test/test-no-package.js:256:9 at node_modules/gitty/lib/repository.js:529:5 at ChildProcess.exithandler (child_process.js:202:7) at maybeClose (internal/child_process.js:885:16) at Socket.<anonymous> (internal/child_process.js:334:11) at Pipe._handle.close [as _onclose] (net.js:501:12) 3) expand (no package.json) homepage should add repository when setting hompage: AssertionError: 'Christopher%20Hiller/project-no-package' == 'jonschlinkert/project-no-package' + expected - actual -Christopher%20Hiller/project-no-package +jonschlinkert/project-no-package at Context.<anonymous> (test/test-no-package.js:281:14) at test/test-no-package.js:256:9 at node_modules/gitty/lib/repository.js:529:5 at ChildProcess.exithandler (child_process.js:202:7) at maybeClose (internal/child_process.js:885:16) at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)FWIW, this is my .gitconfig. If the format is invalid, Git is not complaining about it.
This is where I gave up and decided to tell you about it. 😄
Anyway, once I disabled the weirdness caused by
expand-pkg'slib/expanders/git.js, I got some contributors:{ "contributors": [ "TJ Holowaychuk <tj@vision-media.ca> (http://tjholowaychuk.com)", "Christopher Hiller <boneskull@boneskull.com> (https://boneskull.com)", "Travis Jeffery <tj@travisjeffery.com> (https://twitter.com/travisjeffery)", "Daniel St. Jules <danielst.jules@gmail.com> (http://danielstjules.com)", "David da Silva <yo@dasilvacont.in> (http://dasilvacont.in)", "Guillermo Rauch <rauchg@gmail.com> (http://twitter.com/rauchg)", "Ariel Mashraki <ariel@mashraki.co.il> (https://twitter.com/arielmashraki)", "Attila Domokos (http://www.adomokos.com)", "John Firebaugh (https://github.com/jfirebaugh)", "Nathan Houle <nathan+github@nathanhoule.com> (http://nathanhoule.com)", "Jo Liss <joliss42@gmail.com> (https://twitter.com/jo_liss)", "(https://github.com/jugglinmike)", "Nathan Rajlich <nathan@tootallnate.net> (http://n8.io)", "Brendan Nee <brendan@blinktag.com> (http://blinktag.com)", "Glen Mailer <glen@stainlessed.co.uk> (http://stainlessed.co.uk)", "James Carr <james.r.carr@gmail.com> (http://blog.james-carr.org)", "Domenic Denicola <d@domenic.me> (https://domenic.me)", "Scott Santucci <ScottFreeCode@gmail.com> (https://ScottFreeCode.github.io)", "Aaron Heckmann <aaron.heckmann+github@gmail.com> (http://twitter.com/aaronheckmann)", "Mislav Marohnić <mislav.marohnic@gmail.com> (http://mislav.net)", "Peter Müller <munter@fumle.dk> (https://mntr.dk)", "Ryunosuke Sato <tricknotes.rs@gmail.com> (http://tricknotes.hateblo.jp)", "Kazuhito Hokamura (http://webtech-walker.com)", "Forbes Lindesay (http://www.forbeslindesay.co.uk)", "jongleberry <me@jongleberry.com> (twitter.com/jongleberry)", "Joshua Krall <joshuakrall@pobox.com> (https://github.com/jkrall)", "Maximilian Antoni <mail@maxantoni.de> (http://maxantoni.de)", "Jake Verbaten <raynos2@gmail.com> (http://github.com/Raynos)", "Xavier Antoviaque <xavier@opencraft.com> (http://antoviaque.org)", "Andreas Lind <andreas@one.com> (https://github.com/papandreou)", "Ben Bradley (https://github.com/ben-bradley/resume)", "Benjie Gillam (http://www.benjiegillam.com)", "Cory Thomas (https://github.com/dump247)", "Fredrik Enestad <fredrik.enestad@soundtrackyourbrand.com> (http://soundtrackyourbrand.com)", "(https://github.com/jldailey)", "Merrick Christensen <merrick.christensen@gmail.com> (http://www.merrickchristensen.com)", "Michael Demmer (https://github.com/demmer)", "Nathan Bowser <nbowser@gmail.com> (nathanbowser.com)", "Paul Miller <paul+gh@paulmillr.com> (paulmillr.com)", "Rico Sta. Cruz <hi@ricostacruz.com> (http://ricostacruz.com)", "Sindre Sorhus <sindresorhus@gmail.com> (https://twitter.com/sindresorhus)", "Sune Simonsen <sune@we-knowhow.dk> (https://github.com/sunesimonsen)", "Tyson Mote <tyson@bufio.net> (http://stovepipestudios.com)", "Valentin Agachi (http://agachi.name)", "Wil Moore III <wil.moore@wilmoore.com> (http://wilmoore.com)", "eiji.ienaga (http://friendfeed.com/haru01)", "Zhouxuan Yang <fool2fish@gmail.com> (http://fool2fish.cn)", "Adam Gruber (https://github.com/adamgruber)", "Alex Early (http://aeflash.com)", "Arian Stolwijk <stolwijk.arian@gmail.com> (http://www.aryweb.nl)", "Avi Vahl (https://github.com/AviVahl)", "", "Brian Beck <exogen@gmail.com> (http://brianbeck.com)", "Buck Doyle (https://github.com/backspace)", "Christian (http://www.rndm.de)", "", "", "Ian Storm Taylor (http://ianstormtaylor.com)", "", "Jacob Wejendorp (http://dorp.io)", "James Nylen <jnylen@gmail.com> (https://about.me/jnylen)", "John Reeves (http://jonnyreeves.co.uk)", "", "", "Konstantin Käfer <mail@kkaefer.com> (https://kkaefer.com)", "Long Ho <holevietlong@gmail.com> (https://medium.com/@longho)", "", "", "", "", "", "", "", "", "", "Simon Gaeremynck (http://www.gaeremynck.com)", "", "", "", "", "Xavier Damman <xdamman@gmail.com> (http://xdamman.com)", "", "", "", "", "", "", "", "", "(https://github.com/aaroncrows)", "", "", "", "", "Andrew Nesbitt <andrewnez@gmail.com> (http://nesbitt.io)", "", "", "", "", "", "", "", "", "", "Benoit Larroque (https://github.com/zetaben)", "", "", "Berker Peksag <berker.peksag@gmail.com> (http://berkerpeksag.com)", "", "", "", "", "", "", "", "", "Charles Lowell <cowboyd@frontside.io> (http://frontside.io)", "", "", "", "", "", "", "", "", "", "", "", "Dominic Barnes <dominic@dbarnes.info> (http://dbarnes.info)", "Douglas Wilson <doug@somethingdoug.com> (https://github.com/dougwilson)", "", "", "", "", "", "", "", "", "", "", "", "", "Greg Perkins <gregperkins@alum.mit.edu> (https://twitter.com/gregrperkins)", "", "", "", "", "", "", "", "", "", "", "", "", "", "James Lal <james@lightsofapollo.com> (http://blog.lightsofapollo.com)", "", "", "", "", "", "", "", "Jeremy Martin (https://twitter.com/jmar777)", "", "João Moreno (http://resume.joaomoreno.com)", "Joey Cozza <joeycozza@gmail.com> (https://github.com/joeycozza)", "John Doty <jrhdoty@gmail.com> (https://github.com/jrhdoty)", "", "Jonas Dohse (https://github.com/dohse)", "(https://github.com/jcreamer898)", "", "", "Jordan Sexton <jordan@jordansexton.com> (http://jordansexton.com)", "Josh Eversmann (https://github.com/jeversmann)", "Josh Lory (https://github.com/joshlory)", "Julien Wajsberg (http://everlong.org)", "", "", "", "Keith Cirkel (https://www.keithcirkel.co.uk)", "Kent C. Dodds <kent+github@doddsfamily.us> (https://kentcdodds.com)", "Kevin Burke <kev@inburke.com> (https://kev.inburke.com)", "Kevin Conway <kevinjacobconway@gmail.com> (https://github.com/kevinconway)", "Kevin Kirsche <Kev.Kirsche@gmail.com> (https://kevinkirsche.com)", "", "", "", "", "", "", "", "Mal Graty (https://github.com/mal)", "Marc Kuo <marc@routific.com> (https://routific.com)", "Marcello Bastéa-Forte <marcello@cellosoft.com> (http://marcello.cellosoft.com)", "", "", "", "", "", "Matthew Shanley <matthewshanley@littlesecretsrecords.com> (http://littlesecretsrecords.com)", "(https://github.com/mattias-lw)", "Michael Jackson <mjijackson@gmail.com> (http://mjackson.me)", "Mike Olson (http://mwolson.org)", "", "", "Michal Charemza (http://charemza.name)", "Mick Brooks (http://sinking.in/blog)", "Nathan Black <nathan@nathanblack.org> (http://nathanblack.org)", "", "", "olegtsyba <oleg.tsyba.ua@gmail.com> (https://github.com/olegabyst)", "", "", "Pete Hawkins (http://phawk.co.uk)", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "" ] }You can see the current values here.
The text was updated successfully, but these errors were encountered: