Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MPRIS?) Tuna cant grab cover art if not in file metadata #202

Open
space2ninja101 opened this issue Nov 5, 2024 · 7 comments
Open

(MPRIS?) Tuna cant grab cover art if not in file metadata #202

space2ninja101 opened this issue Nov 5, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@space2ninja101
Copy link

space2ninja101 commented Nov 5, 2024

If you're unsure how to properly file a bug report read this.
I need as much information as possible otherwise I can't help you and I'm more inclined to
just close your issue.

Describe the bug
A clear and concise description of what the bug is.
Tuna cant grab album art if its not in the audio file metadata, I've only tested MPRIS.
Suggesting to make Tuna try and grab cover art from an image that is in the directory where the music is played, like how most media players do if it can't find the image in the file metadata.
And if possible grab the image from MPRIS data (not sure if thats possible?)

To Reproduce
Steps to reproduce the behavior:
Play a song without art in the metadata and is instead in the directory of where the music is being played. Use a MPRIS compatible media player.
Connect it to Tuna.
Make an image source in OBS and point it to the cover art file tuna makes.
Placeholder image appears.

Expected behavior
A clear and concise description of what you expected to happen.
The album art to show.

Screenshots
If applicable, add screenshots to help explain your problem.

image

How it looks on the music player and where the cover art is:
image
You can see it has no trouble grabbing it even if its not in the metadata.

Example of what Tuna currently does (grabs the image from the file metadata as seen in the file thumbnails):
image
image

Log
Add the link to your entire obs studio log

https://obsproject.com/logs/SrzHq71YO5QzODaM

Also add the entire crash report, if this issues is about a crash.

Additional context
Add any other context about the problem here.

@space2ninja101 space2ninja101 added the bug Something isn't working label Nov 5, 2024
@space2ninja101
Copy link
Author

okay what the fuck?
11:41:10.860: [tuna] Cover file '/run/media/space/c5cea59d-d3e8-44d6-a7ec-52ade28be6f5/Stuff/Music/Bryan%20Scary/bryan-scary/the-shredding-tears/cover.jpg' does not exist
it exists though?
image

@univrsal
Copy link
Owner

univrsal commented Nov 5, 2024

Is the folder also named "Bryan%20Scary" or "Bryan Scary"? Also what player is that?

@space2ninja101
Copy link
Author

space2ninja101 commented Nov 5, 2024

Is the folder also named "Bryan%20Scary" or "Bryan Scary"? Also what player is that?

the %20 is to indicate its a space
the player is gapless aka g4music

@univrsal
Copy link
Owner

univrsal commented Nov 5, 2024

the %20 is to indicate its a space

Yes, I am aware of that but it does not answer my question.

@space2ninja101
Copy link
Author

space2ninja101 commented Nov 5, 2024

the %20 is to indicate its a space

Yes, I am aware of that but it does not answer my question.

its named bryan scary, i thought saying that would make it clear

@space2ninja101
Copy link
Author

but the issue isnt that multiple songs have no album art showing because its not in the metadata

@univrsal
Copy link
Owner

Your issue is probably the same as #201 try this build https://github.com/univrsal/tuna/actions/runs/11689705334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants