Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading surefire reports on number of tests run from base class #19908

Closed
losipiuk opened this issue Nov 27, 2023 · 3 comments
Closed

Misleading surefire reports on number of tests run from base class #19908

losipiuk opened this issue Nov 27, 2023 · 3 comments

Comments

@losipiuk
Copy link
Member

When we have a common base class with Junit tests and two subclasses which are run concurrently the output of surefire is misleading.
It looks like when first test class completes surefire reports the number of tests which have been run which is sum of tests run so far from both subclasses.
It can be observed with BaseDeltaFailureRecoveryTest which has two subclasses: TestDeltaQueryFailureRecoveryTest and TestDeltaTaskFailureRecoveryTest.

Output:

Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 560.2 s -- in io.trino.plugin.deltalake.TestDeltaQueryFailureRecoveryTest
...
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 630.1 s -- in io.trino.plugin.deltalake.TestDeltaTaskFailureRecoveryTest

https://github.com/trinodb/trino/actions/runs/7000158137/job/19040462459

cc: @martint @findepi

@losipiuk
Copy link
Member Author

Created surefire bug: https://issues.apache.org/jira/browse/SUREFIRE-2217

@losipiuk
Copy link
Member Author

Duplicate of #20113

@losipiuk losipiuk marked this as a duplicate of #20113 Dec 14, 2023
@losipiuk losipiuk closed this as not planned Won't fix, can't repro, duplicate, stale Dec 14, 2023
@findepi
Copy link
Member

findepi commented Dec 15, 2023

Sorry for re-filing same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants