Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedicated OpenSearch connector #11377

Closed
ryn9 opened this issue Mar 8, 2022 · 6 comments · Fixed by #20257
Closed

Add dedicated OpenSearch connector #11377

ryn9 opened this issue Mar 8, 2022 · 6 comments · Fixed by #20257
Labels
enhancement New feature or request

Comments

@ryn9
Copy link

ryn9 commented Mar 8, 2022

Elastic made it latest libraries not work with OpenSearch

Please provide an OpenSearch connector, based off new libraries

Please have a look the blog post about client libraries available for OpenSearch: https://opensearch.org/blog/community/2021/08/community-clients/

@ebyhr ebyhr added the enhancement New feature or request label Mar 9, 2022
@ebyhr ebyhr changed the title Enhancement request - Please provide an OpenSearch connector Add dedicated OpenSearch connector Mar 9, 2022
@sondn98
Copy link

sondn98 commented Feb 27, 2023

Any update on this?

@akshayjain3450
Copy link

akshayjain3450 commented Jun 15, 2023

Any update on this? We are slowly shifting from Elasticsearch to OpenSearch and so we are looking for the same around trino now. Any timeline for this? @ebyhr

@cezar-tech
Copy link

Would be nice to have for my company as well

@mkhludnev
Copy link

fyi,
I just run $ ../../mvnw test -Dtest=TestElasticsearchOpenSearchConnectorTest on master replacining OpenSearch image to "opensearchproject/opensearch:2.11.1"
and got an obvious error:

[ERROR] io.trino.plugin.elasticsearch.TestElasticsearchOpenSearchConnectorTest --
Time elapsed: 112.9 s <<< ERROR!
ElasticsearchStatusException[Elasticsearch exception [type=illegal_argument_except
ion, reason=Action/metadata line [1] contains an unknown parameter [_type]]]

        Caused by: org.elasticsearch.client.ResponseException: method [POST], host
 [http://localhost:58732], URI [/_bulk?refresh=true&timeout=1m], status line [HTTP
/1.1 400 Bad Request]
{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"Action/meta
data line [1] contains an unknown parameter [_type]"}],"type":"illegal_argument_ex
ception","reason":"Action/metadata line [1] contains an unknown parameter [_type]"
},"status":400}

It makes me think to start with checking Elasticsearch 8.11 for beginning.

@mkhludnev
Copy link

Does it make sense from

  1. to copy trino-elasticsearch (master) to trino-opensearch,
  2. replace occurrences ES->OS,
  3. copy ElasticsearchContainer from testcontainer, and
  4. bring up OS insecure just for the beginning?

If it works it let to decouple ES and unblock #20248.
cc @wendigo

@hashhar
Copy link
Member

hashhar commented Jan 2, 2024

cc: @martint

@mkhludnev The outline you propose makes sense. That's how we ended up with the MariaDB connector (copied from MySQL + changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

7 participants