Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted pokemon in games modded with additional Pokemon #5

Open
ABZB opened this issue Apr 24, 2019 · 3 comments
Open

Deleted pokemon in games modded with additional Pokemon #5

ABZB opened this issue Apr 24, 2019 · 3 comments
Labels
undefined behavior Caused by something that was not foreseen, or not handled.

Comments

@ABZB
Copy link

ABZB commented Apr 24, 2019

This is possibly outside the intended scope of the program, but when a save from an Emerald that was modified to have more Pokemon was loaded, all Pokemon in the party were deleted (the only 'new' Pokemon in that save were in the party).

(The particular mod overwrote some of the Glitch Pokemon slots (between Celebi and Treecko) with those Pokemon)

@trigger-segfault
Copy link
Owner

You are correct, unfortunately this is outside of the scope of Trigger's PC. supporting modded games becomes difficult when the structure can vary so much.

Could you leave the name of the game/mod in the title so that others can take note?

@trigger-segfault trigger-segfault added the wontfix This issue will not be fixed, likely because it is out of scope of the project. label Apr 25, 2019
@ABZB ABZB changed the title Deleted party Deleted pokemon in games modded with additional Pokemon Apr 28, 2019
@ABZB
Copy link
Author

ABZB commented Apr 28, 2019

Sure.

This was not a specific mod - I had modded a stock Emerald to insert Pokemon based on the some of the Delta Pokemon from the TCG in the slots between Celebi and Treecko (index numbers 252 and 254 in this case specifically).

I suspect similar issues might arise with mods using any of the empty item indices.

@trigger-segfault
Copy link
Owner

Yeah, it's definitely a guarantee to expect non-existent IDs to produce undefined behavior. I haven't really worked with the codebase since 2016 so I can't recall exactly how it handles things. But my guess would be that it eliminates any undefineds.

@trigger-segfault trigger-segfault added undefined behavior Caused by something that was not foreseen, or not handled. and removed wontfix This issue will not be fixed, likely because it is out of scope of the project. labels Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
undefined behavior Caused by something that was not foreseen, or not handled.
Projects
None yet
Development

No branches or pull requests

2 participants