Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The repo looks a bit overengineered add something to help local development #10

Open
sakashitatakamine opened this issue Nov 6, 2024 · 2 comments

Comments

@sakashitatakamine
Copy link

I'm looking at how to make changes and contribute to the repo, but it all seems very complicated compared to https://github.com/commontorizon/Containerfiles I would prefer if there was some script or something easy to run in my environment instead of having to configure a gitlab CI flow just for my local development.

@leograba
Copy link
Member

leograba commented Nov 8, 2024

Hey @sakashitatakamine, thanks for the feedback.

As we are sunsetting https://github.com/commontorizon/ and starting to accept external Community and Partner contributions in the https://github.com/torizon org, it will be important that external contributions are made easily.

I'll bring your feedback to the team and, when we start making changes related to the contribution process, consider this feedback.

Meanwhile, @leonheldattoradex, do you have any short-term ideas for making it easier to build the containers locally?

@leonheldattoradex
Copy link
Contributor

leonheldattoradex commented Nov 10, 2024

Hey @sakashitatakamine,

do you have any short-term ideas for making it easier to build the containers locally?

This is well documented in the "Developing" section of the README: https://github.com/torizon/torizon-containers?tab=readme-ov-file#developing.

but it all seems very complicated compared

Let me also add that this repo is more complicated because we need full correctness and dependency resolution between each build (image c needs image b that needs image a, and that has to be built in the correct order etc) , which is something the common version doesn't need because the package integration is already done on our side.

The repo has been mostly optimized for release correctness, not for local development, so we'd need to reimplement a lot of the features we use the GitLab pipeline for.

@sakashitatakamine can you expand on the changes you want to make and how a local script would help compared to the solution I linked above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants