Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create_chart doesn't use path_safe class names #293

Open
toonarmycaptain opened this issue May 7, 2020 · 0 comments
Open

create_chart doesn't use path_safe class names #293

toonarmycaptain opened this issue May 7, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@toonarmycaptain
Copy link
Owner

In create_chart.py, when saving a chart and creating dir for class, class names are used, rather than a path_safe_name. This should probably be done by using Class.path_safe_name, which might be easier implemented by creating an object for the chart constructor, but in the interim either by passing the Class object as an argument, or by passing class_name to a sanitiser first.
@toonarmycaptain toonarmycaptain added the bug Something isn't working label May 7, 2020
toonarmycaptain added a commit that referenced this issue Jul 27, 2020
@toonarmycaptain
Use plain tmpdir database rather than in-memory/cached. Fixes appveyor.
f496fbc 
Change test data to avoid prohibited characters in filename.
This issue relates to #293 where JSONDatabase is not using
path_safe_name for filenames: https://github
.com//issues/293

Signed-off-by: David Antonini <toonarmycaptain@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@toonarmycaptain