-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Students with score of zero not appearing in chart. #141
Labels
bug
Something isn't working
Comments
GitMate.io thinks possibly related issues are #83 (Add test for student with no score), #139 (Permit charts with same name. ), #68 (Go straight from create class to new chart.), and #18 (Score entry dialogue/logic). |
toonarmycaptain
added a commit
that referenced
this issue
Feb 6, 2019
Fixes #141 Signed-off-by: David <toonarmycaptain@hotmail.com>
Merged
toonarmycaptain
added a commit
that referenced
this issue
Feb 7, 2019
Better fix for #141 Signed-off-by: David <toonarmycaptain@hotmail.com>
toonarmycaptain
added a commit
that referenced
this issue
Feb 19, 2019
Fixes #141 Signed-off-by: David <toonarmycaptain@hotmail.com>
toonarmycaptain
added a commit
that referenced
this issue
Feb 19, 2019
Better fix for #141 Signed-off-by: David <toonarmycaptain@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When student is given a score of zero, student's avatar not added to chart.
Suspect issue is inherent falsiness of
0
in this line in code for bundling scores with associated avatars. Theif
statement is suppose to filter out students with no score given, but also filters out0
scores.dionysus/dionysus_app/UI_menus/chart_generator/take_chart_data_UI.py
Lines 48 to 50 in 886691c
This could be a desirable feature (not include zeros, or any score below a certain value etc), but would be better implemented optionally and explicitly. Apart from being able to set optionally, implementing such a feature explicitly would prevent unexpected behaviour if the score range includes some negative numbers (eg you lost points while on zero), where scores below and above zero would be included in the chart, but not zeros.
The text was updated successfully, but these errors were encountered: