Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy check to CI workflow. #140

Closed
toonarmycaptain opened this issue Feb 2, 2019 · 4 comments
Closed

Add mypy check to CI workflow. #140

toonarmycaptain opened this issue Feb 2, 2019 · 4 comments
Labels
Testing/CI Testing configuration issues

Comments

@toonarmycaptain
Copy link
Owner

Mypy provides good static type checking. Add it to one or more of the CI tools such that it's reports can be accessed.

Depending on specifics, failing a building a serious issue might be wise.

Related to #120.

@toonarmycaptain toonarmycaptain added the Testing/CI Testing configuration issues label Feb 2, 2019
@toonarmycaptain
Copy link
Owner Author

toonarmycaptain commented Feb 2, 2019

GitMate.io thinks possibly related issue is #27 (Add installation docs).

@toonarmycaptain
Copy link
Owner Author

Expect this to follow on #120, as prematurely adding mypy check will fail.

@toonarmycaptain
Copy link
Owner Author

There are some issues where accepting more than one type eg var: Optional[List] or var Union[str, Path, None] results in mypy having issues with the passing of None to things like .joinpath even though such issue would not happen because it is gated by an if var: etc.

@toonarmycaptain
Copy link
Owner Author

Forgot to close issue, but mypy has been implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing/CI Testing configuration issues
Projects
None yet
Development

No branches or pull requests

1 participant