Gitlab support

[nalkuatov]

We're currently trying to enable the plugin for a project in Gitlab. The inline comments there seem to be rendered quite unexpectedly - there're some closing </tr> tags appearing as a plain text in a comment's resultant html.

Danger system's comment templates seem to be the same for both Gitlab and Github - do you have any ideas why the above happens? And does the plugin support Gitlab?

[tmspzz]

Hey @nalkuatov, I'm not sure I do. The output is grabbed directly from hlint. Maybe there is some additional escaping needed?

[nalkuatov]

Maybe there is some additional escaping needed?

I did try to remove the language syntax highlighting here - regular inline code highlighting works okay (using single backticks, e.g some code here), and as a result, now there're no random </tr> tags appearing in the inline comments.

This seems to be an issue at Danger's inline comments template for GitLab.

[nalkuatov]

I haven't used Ruby before, so I don't have any other ideas for resolving this.

[nalkuatov]

The only solution I can think of is to remove the syntax highlighting here again

[tmspzz]

The only solution I can think of is to remove the syntax highlighting here again

You can try multiline Strings and remove the \n

[nalkuatov]

message = <<~HEREDOC
      Found #{r['hint']}

      ```haskell
        #{r['from']}
      ```

      #{prompt}

      ```haskell
        #{r['to']}
      ```
    HEREDOC

Unfortunately, this doesn't help. Some random </tr>s are still there

[tmspzz]

I guess then there's nothing much to do here. This must be fixed upstream in Danger.

Alternatively you can try to parse the output of Danger and remove the ?