Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This code needs tests around its functionality #3

Open
stsvilik opened this issue Jan 19, 2016 · 4 comments
Open

This code needs tests around its functionality #3

stsvilik opened this issue Jan 19, 2016 · 4 comments

Comments

@stsvilik
Copy link

If you intend to make it popular and growing you will need to put together tests around its functionality. You could start with mocha + istanbul for code coverage.

@tmanderson
Copy link
Owner

I definitely agree with you there. I'll have to dig into the proxy module a bit more (and potentially update this), as it was a contributed from @kuzzmi.

@kuzzmi
Copy link
Contributor

kuzzmi commented Jan 20, 2016

@tmanderson, I'm still here, so if any help is needed, just let me know. Probably the proxy module will require some more testable structure, so I'll take a look at it once again.

@tmanderson
Copy link
Owner

@kuzzmi that would be awesome if you could get started on that! I can follow suit on the main module for the bits that are there.

Thanks!

@stsvilik
Copy link
Author

The proxy error I was getting is “SSL23_GET_SERVER_HELLO:unknown protocol” which was mainly caused by proxy not being able to communicate over https.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants