You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As detailed in PR #575, we updated the code we use for checking IP ranges to support ipv4 and ipv6 addresses by using a different socket method, socket.getaddrinfo when looking up a domain.
What we probably should do when a domain is looked up is check every possible ip address we get back from socket.getaddrinfo, and only return a green result if they all match.
This is here for us to revisit in future, so we don't forget.
The text was updated successfully, but these errors were encountered:
As detailed in PR #575, we updated the code we use for checking IP ranges to support ipv4 and ipv6 addresses by using a different socket method,
socket.getaddrinfo
when looking up a domain.https://github.com/thegreenwebfoundation/admin-portal/pull/575/files
What we probably should do when a domain is looked up is check every possible ip address we get back from
socket.getaddrinfo
, and only return a green result if they all match.This is here for us to revisit in future, so we don't forget.
The text was updated successfully, but these errors were encountered: