Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliance tests are not executed #450

Open
1 of 5 tasks
ate47 opened this issue Feb 15, 2024 · 5 comments
Open
1 of 5 tasks

Compliance tests are not executed #450

ate47 opened this issue Feb 15, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@ate47
Copy link
Collaborator

ate47 commented Feb 15, 2024

Part of the endpoint? (leave empty if you don't know)

  • Backend (qendpoint-backend)
  • Store (qendpoint-backend)
  • Core (qendpoint-core)
  • Frontend (qendpoint-frontend)
  • Other

Description of the issue

At the commit a697f7b (Action: https://github.com/the-qa-company/qEndpoint/actions/runs/7532584712/job/20507616980), the CI isn't executing the compliance tests anymore.

In the previous one 74388b7, they are completed by the CI.

A search for ComplianceTest can find it.

Weirdly they are running on my computer, but are generating a IllegalStateException with the tempPath.

java.lang.IllegalStateException: the temporary folder has not yet been created
image

Excepted behavior

No response

Obtained behavior

No response

How to reproduce

No response

Endpoint version

latest

Do I want to contribute to fix it?

Maybe

Something else?

No response

@ate47 ate47 added the bug Something isn't working label Feb 15, 2024
@ate47
Copy link
Collaborator Author

ate47 commented Feb 15, 2024

@hmottestad, It seems that the compliance tests are using Jupiter, but I've never worked with it so I don't know if the issue is coming from it or not.

@hmottestad
Copy link
Contributor

Jupiter is the name for Junit 5. Jerven migrated those tests from Junit 4. I know there is one issue with the way that they are executed now. The lifecycle hooks don't work correctly. Maybe that is the issue here?

@hmottestad
Copy link
Contributor

Maybe surefire/failsafe maven plugins need to be updated to detect the tests?

@ate47
Copy link
Collaborator Author

ate47 commented Feb 15, 2024

Ok, I've updated that to test in the test-compliances branch, but I get errors, I'll try to see why

https://github.com/the-qa-company/qEndpoint/commits/test-compliances/

@hmottestad
Copy link
Contributor

What's happening now is probably related to the lifecycle issues with the tests. The directory that is created for the new repository is the same for each test, instead of a new directory. So essentially it's starting a repo in a directory, then shutting it down, then starting it back up again. Doing this over and over again should be fine, but I think that qEndpoint probably has some bugs when this happens.

One quick fix would be to create a new directly within the temporary directory, in the new repository method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants