Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing blockFees in rewards calculation #709

Open
legonian opened this issue Jul 19, 2024 · 2 comments
Open

Missing blockFees in rewards calculation #709

legonian opened this issue Jul 19, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@legonian
Copy link

legonian commented Jul 19, 2024

Describe the bug
After the Paris update in the src/tzkt/tzkt_reward_api.py file, the use of the blockFees reward in rewards_and_fees calculation is missing, so now all generated rewards are slightly lower.

To Reproduce
Steps to reproduce the behavior:

  1. Take any validator and cycle with non-empty blockFees
  2. Compare the generated delegator reward amount with TzKT explorer's expected reward (the income column that already includes the validator fee and should match the generated result https://tzkt.io/tz1RitQmGzcbH2j9uNt9Wau5BpFPeEHyrkvj/rewards)
@legonian legonian added the bug Something isn't working label Jul 19, 2024
@nicolasochem
Copy link
Contributor

we are not including the block fees into the reward distribution anymore, because the stakers don't get any block fees, so it would be strange if delegators received them.

@legonian
Copy link
Author

legonian commented Aug 1, 2024

But TzKT explorer showing the value Delegation income that calculated using blockFees amount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants