Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to change close button behaviour (minimize or send to background) #28826

Closed
iAweX opened this issue Jan 4, 2025 · 12 comments
Closed

Option to change close button behaviour (minimize or send to background) #28826

iAweX opened this issue Jan 4, 2025 · 12 comments

Comments

@iAweX
Copy link

iAweX commented Jan 4, 2025

Is your feature request related to a problem?

After update to v5.10 close button does not minimize to taskbar (dash to dock) on Linux. Behaviour of close button with tray icon disabled that existed for a long time was changed without offering the option to restore it.

#28824

Describe the solution you'd like

Option to change close button behaviour (minimize or send to background)

Describe alternatives you've considered

Restore previous behaviour

Additional context

No response

@ilya-fedin
Copy link
Contributor

#8941?

@iAweX
Copy link
Author

iAweX commented Jan 4, 2025

GNOME, by default doesn't have tray (you need to install 3rd party extensions to enable it) and minimize button (you should use tweaks to enable it) . Before tdesktop v5.10, cross (close button) with tray icon disabled just minimized app to taskbar, so you can see that app is running and switched to it from overview or using alt+tab.

In version 5.10 this behaviour was changed without any ability to restore previous behaviour. Now cross (close button) sends app to background, so you have to click desktop file (icon) to make the app active. It's very inconvenient in default GNOME without extensions and tweaks, especially for those who new to Linux and GNOME and those who prefer default clean GNOME.

@ilya-fedin
Copy link
Contributor

Actually, this behavior was since a long time for GNOME. Since v5.10, the same behavior is used for non-GNOME too. Apparently the detection was just broken for you for some reason.

@iAweX
Copy link
Author

iAweX commented Jan 4, 2025

I think that users should be given the ability to choose what the close button does:

  1. Closes the application
  2. Sends it to the background
  3. Minimizes to taskbar

@iAweX
Copy link
Author

iAweX commented Jan 4, 2025

Actually, this behavior was since a long time for GNOME. Since v5.10, the same behavior is used for non-GNOME too. Apparently the detection was just broken for you for some reason.

Very interesting, what can broke this. I tried to downgrade to 5.9 and it works as expected. So I think it's not OS related issue.

@ilya-fedin
Copy link
Contributor

There's a problem with minimization to taskbar: not all wms support it and we get reports about that (#28646, #28763), the underlying toolkit (Qt) doesn't have API to check the support so the only way to be safe is to not to have this option on Linux at all.

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Jan 4, 2025

Very interesting, what can broke this. I tried to downgrade to 5.9 and it works as expected. So I think it's not OS related issue.

By this behavior, I mean running in background. It was always on GNOME/Pantheon. If you haven't had it before 5.10, it means your system wasn't recognized as GNOME and there was a bug in GNOME detection. Since 5.10, running in background is the behavior for all Linux.

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Jan 4, 2025

I think that users should be given the ability to choose what the close button does:

Your issue is a third variation for the option to control the behavior of the cross. I believe we don't need that much issues about that, #8941 is enough.

@iAweX
Copy link
Author

iAweX commented Jan 4, 2025

#28646 is about Alpine Linux and #28763 is about Hyprland.

Alpine mostly used for servers and Hyperland (or other WM without taskbar) is for geeks. And what about GNOME users, who doesn't have tray and minimize button by default?

GNOME, by default doesn't have tray (you need to install 3rd party extensions to enable it) and minimize button (you should >use tweaks to enable it) . Before tdesktop v5.10, cross (close button) with tray icon disabled just minimized app to taskbar, so >you can see that app is running and switched to it from overview or using alt+tab.

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Jan 4, 2025

And what about GNOME users, who doesn't have tray and minimize button by default?

Well, they are who asked this behavior since a long time (search closed issues for "run in background") and, as I already said multiple times, you should have experienced it even before 5.10, but due to some bug in detection you had the non-GNOME behavior. idk why but most GNOME users hated Telegram being in overview. Personally I'm not a GNOME user and idk what is the right behavior so I did what most users asked.

@iAweX
Copy link
Author

iAweX commented Jan 4, 2025

OK.

May be there is some workaround to enable behavior that I described?

@ilya-fedin
Copy link
Contributor

As I already said I'm not a GNOME user but I guess you can pin tdesktop somewhere for fast access? Or, well, install a tray extension? I also heard GNOME shows running flatpak apps in some list on panel...

@Aokromes Aokromes closed this as completed Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants