New Usb code doesn't work

[wiiznokes]

Hi, i saw you made some improvements to the code so i tested it.
It's nice that you have found a crate for adb. I see you changed the Streamer architecture. I'm not convinced it's better because

• you're using a Mutex on the shared buffer
• when using Drop for shutdown, we are sure it will be called.
• in my experience, it's easier to reason about a stream of event instead of a Mutex. This avoid some race bugs.

Sadly, both Usb methods have not worked, here are some info:

adb:

• clicking connect PC side
• Clicking connect Android side
• Android seems to be connected, nothing happens in the Rust app

log android:

2024-12-13 17:16:25.451  9926-9926  MainViewModel           com.example.androidMic.proto         D  onConnectButton: start stream
2024-12-13 17:16:25.452  9926-12327 MicService              com.example.androidMic.proto         D  startStream [start]
2024-12-13 17:16:25.456  9926-12327 MicService              com.example.androidMic.proto         D  startStream [connected]
2024-12-13 17:16:28.555  9926-12256 UsbAdbStreamer          com.example.androidMic.proto         D  Broken pipe
2024-12-13 17:16:28.566  9926-12256 UsbAdbStreamer          com.example.androidMic.proto         D  disconnect: complete

Note that the Android App still show a Connected state even tho the stream seems to have ended.
And for Rust, when clicking "Stop listenning", and connect again, we are blocked in the waiting state (probably a race condition).

For Usb serial:

Note sure if i need to connect in a certain way, but here are the logs:

Log Rust :

[2024-12-13T17:20:00Z INFO  android_mic::streamer::usb_streamer] Checking USB device at 0x2: unknown, AURA LED Controller, 0xB05 0x1939
[2024-12-13T17:20:00Z INFO  android_mic::streamer::usb_streamer] Checking USB device at 0x4: unknown, AMD SR4 lamplight Control, 0x2516 0x51
[2024-12-13T17:20:00Z INFO  android_mic::streamer::usb_streamer] Checking USB device at 0x1: unknown, Gaming keyboard, 0x4D9 0xA1CD
[2024-12-13T17:20:00Z INFO  android_mic::streamer::usb_streamer] Checking USB device at 0x6: unknown, OnePlus 6T, 0x18D1 0x4EE2
[2024-12-13T17:20:00Z INFO  android_mic::streamer::usb_streamer] Checking USB device at 0x2: unknown, G502 HERO Gaming Mouse, 0x46D 0xC08B
[2024-12-13T17:20:00Z INFO  android_mic::streamer::usb_streamer] Checking USB device at 0x1: unknown, unknown, 0x8087 0x29
[2024-12-13T17:20:00Z ERROR android_mic::streamer::streamer_sub] NoUsbDevice(
        Custom {
            kind: Other,
            error: "No android phone found",
        },
    )

Log Android:

2024-12-13 17:20:34.486  9926-12327 MicService              com.example.androidMic.proto         D  start stream with mode USB failed:
                                                                                                    No USB device detected

[teamclouday]

Hey thanks for testing it!

Regarding the changes to streamer architecture, it was changed in order to use a USB library called rusb, which maintains a USB connection with custom lifetime. Separating the initialization code and polling code makes it harder to keep the lifetime.
Later I found another USB library nusb, which maintains the connection in global context and is better, so I started using that. By the time the changes were already made, so I didn't revert it. Both should work, but there were some racing issues. Usually can be fixed by reordering the mutex positions. Another problem with current code is there might be error results overwrited by new ones so there's that missing information, although the console has all the logs.

Regarding the mutex on shared buffer. It was created because the buffer can be swapped when audio configuration has changed. The mutex is there to protect read/write on discarded buffer. But I'm not very familiar with the rtrb library, does it require an explicit drop in order to get cleared in memory?

Adb streamer needs some debugging. It's weird if tcp works but adb has been blocking. I haven't tested it yet tbh. For USB streamer, I notice your phone manufacturer is oneplus, there's a line here

AndroidMic/RustApp/src/streamer/usb_streamer.rs

Line 34 in a670e73

const VENDOR_NAME_LIST: [&'static str; 1] = ["samsung"];

that hard coded the manufacturer in order to be able to recognize the phone from all usb devices. You can try putting oneplus there and see if it works. I'm new to usb things. Maybe there are better ways to detect the phone device and I'm sure there's room for improvement

[teamclouday]

One more thing about USB mode, is that you want to close the app, change to charging only, and let the rust app run first. It will turn your phone into accessory mode and start the app later

[wiiznokes]

I will try to look into it in the next weeks