-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note name sending extension support #1468
Comments
Yeah note name Support is a good idea but indeed we have the problem of not having a single name per zone so we do need to think about what to do and report |
My thinking is we allow naming keys on Settings tab of the instrument (see wireframe) and serialize that along with the patch. If loading multiple instruments they get coalesced. In case of overlaps in naming (same key named differently by more than one loaded patch), latest one loaded takes precedence (concatenating would be practically useless in piano roll view). |
Yea and I think defaulting to name of sample would be a good fallback if no name is manually provided Also note, DAW such as REAPER already has manual notenames entry feature for plugins that lack it |
I think this needs to be more explicit, since it's so very easy to overlap keys when mapping zones, I'd rather if the key names were all manually set up. Also, samples oftentimes have very ugly filenames... :P |
Yes I agree make explicit should be possible either case. It's just for ease of use Ableton's drum rack does this already with no intervention needed from the user. As a user I just want the names to appear if I put some samples and thats it. Since thats what im used to coming from other DAW Not writing note names by hand if user doesn't want to is whole point of feature in my mind, afterall could just use Reaper 's manual note names already without needing shortcircuit version For that specific use case (drumrack) I dont think it should be that hard to show just sample name if no samples overlap If overlap exist, I thought by default "HiHat Open.wav [...]" To show multi sample. Showing last selected instrument. If user does not override yet |
The point is once you explicitly store note names to a SC patch, it is portable across hosts which support the note name API. Reaper's solution only works in Reaper. |
Yes that's true, I just hope can get acceptable notenames with as little manual effort as possible |
I found easy to work with when note name support like Reaper shows "note of type is active here"
However plugin like NI Battery does not send these so user has to manually keep track of notenames and it becomes hard !
For CLAP, code is like the note name example plugin here
https://github.com/free-audio/clap-juce-extensions/blob/main/examples/NoteNamesPlugin/NoteNamesPlugin.cpp
I looked into my self but for this plug-in seems more complex than first glance. Example in shortcircuit xt: notes can have different vel ranges, notes can span more than one key, groups can overlap with each other, groups can be enabled/disabled conditionally ...
I think its best if at least DAW reports "note can be active here". If one can narrow down to one note name then provide the name. Otherwise ... something else ? "2 notes here ?"
But I think this will require some planning as to best user experience, what you think ?
The text was updated successfully, but these errors were encountered: