Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Num/Denom controls on zone pitch #1400

Open
Andreya-Autumn opened this issue Oct 1, 2024 · 9 comments
Open

Num/Denom controls on zone pitch #1400

Andreya-Autumn opened this issue Oct 1, 2024 · 9 comments
Labels
Design Required We need to design a solution to this issue Feature Request New feature request UI Issues related to UI look&feel UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.

Comments

@Andreya-Autumn
Copy link
Collaborator

Discussing harmonic ratios of playback and such with Kinsey today, it occurs that this could be really cool. Just a N and D with range 1...16 like in the FM filter or Ring Mod procs.

There is room for it:
Barely

Let's try it sometime! Getting it reasonably modulatable will take some thought I think. I think the way I'd do it is put a tiny slew on the pitch changes introduced by those controls on the engine side, to avoid the most horrible clicks. Some experimenting needed.

@Andreya-Autumn Andreya-Autumn added Feature Request New feature request Design Required We need to design a solution to this issue UI Issues related to UI look&feel UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels Oct 1, 2024
@Andreya-Autumn
Copy link
Collaborator Author

I guess another question is if this should be on zone pitch (including processors) or on sample playback. I would be inclined to lean towards sample playback, because how cool would it be to send samples at varying playback ratios into a string resonator (with the resonator at the root note). But other thoughts welcome.

@mkruselj
Copy link
Collaborator

mkruselj commented Oct 1, 2024

I kinda think this should be a mode on the tuning control itself. Right-click set to ratio mode. goes from 1/16 to 16x. Done.

@Andreya-Autumn
Copy link
Collaborator Author

Hmmm it really really needs two controls though. -16...16 is about 1% as useful as num/denom each being 1...16

@Andreya-Autumn
Copy link
Collaborator Author

But what we could do is use the one-knob idiom that we discussed on LFO rates!

@mkruselj
Copy link
Collaborator

mkruselj commented Oct 1, 2024

I think the UI room is too tight for that here. Right-click set to Ratio mode and the second value edit appears to the left, that should be fine tho.

There is zero room for this on SAMPLE pane, tho.

@Andreya-Autumn
Copy link
Collaborator Author

Yeah and we also said Sample pane params aren't mod targets...

I do like the RMB idea but I wonder what happens if you need a fine tune as well. Hmmm...

@mkruselj
Copy link
Collaborator

mkruselj commented Oct 1, 2024

You can then finetune at sample level? I think this is a perfectly acceptable compromise.

@Andreya-Autumn
Copy link
Collaborator Author

Yeah good point! That control would then affect the whole zone playback (including procs) right? Like the regular pitch control does. Anything else would be counterintuitive.

In the mod matrix right now we have one target for zone pitch and one for sample pitch (affecting all variants). The latter doesn't have a control on the UI. If/when we get these modulatable we could do the same there.

@mkruselj
Copy link
Collaborator

mkruselj commented Oct 1, 2024

Yeah good point! That control would then affect the whole zone playback (including procs) right? Like the regular pitch control does. Anything else would be counterintuitive.

Yes, of course. doesn't make sense to have it any other way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Required We need to design a solution to this issue Feature Request New feature request UI Issues related to UI look&feel UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Development

No branches or pull requests

2 participants