-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test case for remapping of absolute paths in panic messages #1704
Comments
brson
added a commit
to brson/soroban-cli
that referenced
this issue
Dec 11, 2024
brson
added a commit
to brson/soroban-cli
that referenced
this issue
Dec 11, 2024
brson
added a commit
to brson/soroban-cli
that referenced
this issue
Dec 11, 2024
fnando
pushed a commit
that referenced
this issue
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #1594 we added a fetature to remap absolute file paths in panic messages (and debuginfo) to relative paths, for reproducibility.
That issue did not land any tests - the feature is complicated to test, but we did discuss methods for testing it.
Also in that thread it was mentioned that we probably screwed up on windows specifically, because the feature as implemented does not work with spaces in paths, and windows home directories commonly contain spaces.
Let's write a test and fix the implementation on windows.
The text was updated successfully, but these errors were encountered: